Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Rename buildpacks to runpacks visually #367

Merged
merged 1 commit into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/apps/appstats.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<td>{{ appData.spec.deploymentstrategy }}</td>
</tr>
<tr v-if="appData.spec.deploymentstrategy == 'git' && appData.spec.deploymentstrategy == 'plain'">
<th>Buildpack</th>
<th>Runpack</th>
<td>{{ appData.spec.buildpack }}</td>
</tr>
<tr v-if="appData.spec.deploymentstrategy == 'git'">
Expand Down
8 changes: 4 additions & 4 deletions client/src/components/apps/form.vue
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
<v-radio-group v-model="buildstrategy">
<v-radio
key="0"
label="Plain images"
label="Runpacks"
value="plain"
></v-radio>
<v-radio
Expand Down Expand Up @@ -181,9 +181,9 @@

<v-alert variant="tonal" color="#8560a9" border="start" v-if="buildstrategy == 'plain'">
<h3>
Plain
Runpacks
</h3>
<div>This is the default for kubero. Your code is running on official images. The code will be built for every pod. This is the fastes way, to run your code, but becomes more inefficient with every replica.</div>
<div>Your code is build and running on official images. The code will be built for every pod in a init container. This is the fastes way, to run your code, but becomes more inefficient with every replica.</div>
</v-alert>

<v-alert variant="tonal" color="#8560a9" border="start" v-if="buildstrategy == 'nixpacks'">
Expand Down Expand Up @@ -284,7 +284,7 @@
<v-select
v-model="buildpack"
:items="buildpacks"
label="Buildpack"
label="Runpack"
@change="updateBuildpack(buildpack)"
></v-select>
</v-col>
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/settings/form-buildpacks.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
type="info"
variant="tonal"
style="margin-bottom: 20px; margin-top: 20px;"
text="These buildpacks are used only for apps using the 'plain' build strategy">
text="These Runpacks are used only for apps using the 'Runpacks' build strategy">
</v-alert>
<v-expansion-panels
v-model="panel"
Expand Down
4 changes: 2 additions & 2 deletions client/src/components/settings/form.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
>
<v-tab value="general">General</v-tab>
<v-tab value="podsizes">Podsizes</v-tab>
<v-tab value="buildpacks">Buildpacks</v-tab>
<v-tab value="runpacks">Runpacks</v-tab>
<v-tab value="deployment">Deployment</v-tab>
<v-tab value="templates">Templates</v-tab>
<v-tab value="notifications">Notifications</v-tab>
Expand All @@ -25,7 +25,7 @@
<FormPodsizes :settings="settings.settings"></FormPodsizes>
</v-window-item>

<v-window-item value="buildpacks">
<v-window-item value="runpacks">
<FormBuildpacks :settings="settings.settings"></FormBuildpacks>
</v-window-item>

Expand Down
Loading