Merge pull request #172 from kubero-dev/fix/pipeline-delition

Fix / Improve pipeline delete
kubero-dev · May 29, 2023 · 102c8c7 · 102c8c7
2 parents 4e53972 + cdfd438
commit 102c8c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/client/src/components/pipelines/list.vue b/client/src/components/pipelines/list.vue
@@ -22,7 +22,7 @@
                     </v-col>
                 </v-row>
 
-                <v-row v-for="item in apps" :key="item.name">
+                <v-row v-for="item in apps" :key="item.name" :id="item.name">
                     <v-col cols="12">
                         <v-card elevation="2" outlined color="cardBackground">
                             <v-card-text>
@@ -118,10 +118,12 @@ export default {
         });
       },
       deletePipeline(app) {
+        document.querySelector(`#${app}`).style.display = "none";
+
         axios.delete(`/api/pipelines/${app}`)
         .then(response => {
             console.log(response);
-            this.loadPipelinesList();
+            //this.loadPipelinesList();
         })
         .catch(error => {
             console.log(error);

diff --git a/src/kubero.ts b/src/kubero.ts
@@ -205,7 +205,7 @@ export class Kubero {
             if (pipeline) {
                 await this.kubectl.deletePipeline(pipelineName);
 
-                // TODO: lines not working, since object may still exist in the API
+                await new Promise(resolve => setTimeout(resolve, 5000)); // needs some extra time to delete the namespace
                 this.updateState();
                 this._io.emit('updatedPipelines', "deleted");
                 this.kubectl.createEvent('Normal', 'Deleted', 'pipeline.deleted', 'deleted pipeline: '+pipelineName);