Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pod generation to docs for v1.33 #49906

Merged
merged 1 commit into from
Apr 2, 2025
Merged

add pod generation to docs for v1.33 #49906

merged 1 commit into from
Apr 2, 2025

Conversation

natasha41575
Copy link

Description

Add pod generation info to pod update docs

Issue

Pod generation KEP: kubernetes/enhancements#5067

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit dd082cd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67eaa370ac986f000801f981

@natasha41575 natasha41575 mentioned this pull request Feb 25, 2025
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dd082cd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67eaa370cbcaaa00081278ad
😎 Deploy Preview https://deploy-preview-49906--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rayandas
Copy link
Member

Hello @natasha41575 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@natasha41575 natasha41575 marked this pull request as ready for review March 25, 2025 14:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@natasha41575
Copy link
Author

/cc @tallclair

@k8s-ci-robot k8s-ci-robot requested a review from tallclair March 28, 2025 15:41
@natasha41575
Copy link
Author

/assign @sftim

do you mind reviewing this one? since you also reviewed the kep :)

@tengqm
Copy link
Contributor

tengqm commented Mar 29, 2025

Where is the upstream source code change?
We are not supposed to merge doc changes before code changes happening.
Also, please do not expect the docs team to track all KEP changes considering that we are short of hands/eyes.

@natasha41575
Copy link
Author

natasha41575 commented Mar 29, 2025 •
edited
Loading

Where is the upstream source code change? We are not supposed to merge doc changes before code changes happening. Also, please do not expect the docs team to track all KEP changes considering that we are short of hands/eyes.

@tengqm All code changes are linked in the enhancements issue kubernetes/enhancements#5067 (which I put in the pr description). Adding the full list here too:
- kubernetes/kubernetes#130181
- kubernetes/kubernetes#130352
- kubernetes/kubernetes#130573
- kubernetes/kubernetes#130649
- kubernetes/kubernetes#130650

@tengqm
Copy link
Contributor

tengqm commented Mar 30, 2025

@natasha41575 Thanks for the info.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2025
@natasha41575 natasha41575 changed the title add pod generation to docs add pod generation to docs for v1.33 Mar 31, 2025
@natasha41575 natasha41575 requested a review from tengqm March 31, 2025 14:16
@natasha41575
Copy link
Author

/unassign @sftim
/assign @tengqm

@k8s-ci-robot k8s-ci-robot assigned tengqm and unassigned sftim Mar 31, 2025
@natasha41575
Copy link
Author

natasha41575 commented Apr 1, 2025 •
edited
Loading

btw @tengqm just want to flag that I won't be available after this Friday afternoon to address any comments so will need to get the lgtm tag before then to make this in for docs freeze

@tengqm
Copy link
Contributor

tengqm commented Apr 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c56ffae91d39e0bac3067ee83bc8287e30ead8f5

@k8s-ci-robot k8s-ci-robot merged commit df81e6b into kubernetes:dev-1.33 Apr 2, 2025
6 checks passed
@natasha41575 natasha41575 deleted the pod-generation-docs branch April 2, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@Princesso Princesso Awaiting requested review from Princesso

@reylejano reylejano Awaiting requested review from reylejano

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@tallclair tallclair Awaiting requested review from tallclair

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natasha41575 @rayandas @tengqm @k8s-ci-robot @sftim