-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign KubeCon links on the main page #49167
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think we could use a more comprehensive redesign of our landing page. This is progress. However, we shouldn't merge this as-is @shurup. Please look at the localized versions of this page; you'll see that the proposed change will break rendering for some (eg Korean). |
Good catch, thank you! I will find a way to keep the "backward compatibility." P.S. Regarding a more general redesign of this page, I was actually thinking of suggesting some new options to replace that old video (behind the KubeCon links) as my next step... |
Signed-off-by: Dmitry Shurupov <[email protected]>
b9f2a8a
to
e49c25c
Compare
It's done. I added "old-fashioned" |
Thanks! /lgtm |
LGTM label has been added. Git tree hash: e8fe29bfafbf4608dcb3d69f971be52f3c7b26b5
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: katcosgrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
I'm suggesting this redesign of the "Attend KubeCon…" block on the main page (see After):
In my understanding, it's needed since we have five KubeCons now, and adding more huge buttons (as we did before — see Before) won't really work anymore.
While working on this design improvement, I've also noticed a long-standing HTML bug since we had such entities for the KubeCon links for many years:
<a href="..." button id="desktopKCButton">
. They are not valid for two reasons: a) the<a>
tag does not have thebutton
attribute, and b) we can't use the sameid
for numerous HTML objects on the same page. Thus, I removed thebutton
attribute and converteddesktopKCButton
fromid
toclass
.UPDATE: To maintain back compatibility with the localised pages having old content at the moment, I left the
#desktopKCButton
blocks in the CSS file, which we'll be able to remove later (i.e. when all localisations switch to the new HTML code for KubeCon links).Obviously, I've also synced the actual KubeCon events (links & dates) with the upcoming 2025 events.
I've checked how the suggested changes are rendered in two browsers (Firefox and Chrome in Linux). However, more testing, as well as general feedback, will be very much appreciated.