Update branch based context to production for Netlify #49153
Conversation
This removes the branch based context of "context.main" which would be triggered and override any other contexts even during the PR cycle. The assumption here is that "production" context is marked appropriately on Netlify admin UI, and once it's in place, this should have the same effect to ensure we do not publish any draft or future date posts.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5ecf6c4706af9cf3e52784f59902742539e188dc
|
|
@sftim I'd be happy to test from my end as well! It would probably involve having a few draft (dummy) blogs, PRs, test merge to main branch, and potentially checking the Netilfy status. I'm not sure how much I can cover with my entitlements, but should be able to support a few cases. |
Description
This removes the branch based context of "context.main" which would be triggered and override any other contexts even during the PR cycle. The assumption here is that "production" context is marked appropriately on Netlify admin UI, and once it's in place, this should have the same effect to ensure we do not publish any draft or future date posts.
Other
I'm not fully familiar with Netlify, and this is an attempt to solve the draft blog posts to be reviewed in the future (this was originally highlighted in #48962 and tested with #48998). While I believe we need Netlify build to handle PRs better, this would need to be checked carefully as it could impact the website as a whole.