Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PV Storage Task #49130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

network-charles
Copy link
Contributor

Description

This PR improves the explanation of this section titled "Mounting the same persistentVolume in two places" in the Configure a Pod to Use a PersistentVolume for Storage page.

  1. I used the existing PV and PVC in this example.
  2. I created a new nginx.conf file to show the file referenced in the pods manifest.
  3. I explained why a subPath is used.

Issue

Closes: #43293 and #49119

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from sftim December 17, 2024 06:02
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit be8da21
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67615fc3bcfb5100086004ab
😎 Deploy Preview https://deploy-preview-49130--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Dec 17, 2024

Also relevant to #45873

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK; one nit

Co-authored-by: Tim Bannister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/tasks/configure-pod-container/configure-persistent-volume-storage/
3 participants