Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ComponentSLIs as GA in 1.32 #48603

Closed
wants to merge 1 commit into from
Closed

Mark ComponentSLIs as GA in 1.32 #48603

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Oct 31, 2024

Upstream PR: kubernetes/kubernetes#128317
Status: merged

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d0bf994
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67231b7699deb200081e032a

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024

✅ Pull request preview available for checking

Name Link
🔨 Latest commit d0bf994
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67231b76fd2c050008006f60
😎 Deploy Preview https://deploy-preview-48603--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

@tengqm, changes seem good, curious to know, why it is showing (enabled by default: true) in the feature state, is it due to the v1.32 branch?

Here is the preview screenshot:

Screenshot

@Shubham82
Copy link
Contributor

/sig instrumentation
/sig docs

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 4, 2024
@tengqm
Copy link
Contributor Author

tengqm commented Nov 4, 2024

I have no idea why there is a "enabled by default" note. My guess is that note comes from
the feature_state shortcode.

sftim
sftim reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(for docs)

This change will make the docs less wrong.

content/en/docs/reference/instrumentation/slis.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With SLI metrics enabled, each Kubernetes component exposes two metrics,
labeled per healthcheck:

Does this text also need to change? I think the endpoint is now served unconditionally.

content/en/docs/reference/command-line-tools-reference/feature-gates/component-slis.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b033e468779d17d3f43cf79746b804d18380dae8

@tengqm tengqm closed this Nov 12, 2024
@tengqm tengqm deleted the fg-csli-132 branch November 12, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@logicalhan logicalhan Awaiting requested review from logicalhan

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@sftim sftim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@tengqm @k8s-ci-robot @Shubham82 @sftim