-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog Post: Introducing JobSet #45759
base: main
Are you sure you want to change the base?
Conversation
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
/cc @haircommander Trying to find an impartial reviewer ;) |
I have one note but I found this informative while doing a good job of laying the groundwork needed. LGTM (assuming the note is unaddressable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some partial feedback (not yet a full review)
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/jobset_diagram.png
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
(if this is not yet ready for review by the blog team, please change the title to start with |
/hold pending assignment of publication date |
Thanks Tim, added |
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
I propose the 26th of April as publication date. Does that work? |
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-04-02-introducing-jobset/2024-04-02-introducing-jobset.md
Outdated
Show resolved
Hide resolved
Let's pick a new publication date. How about the 7th of May? |
You should remove |
/lgtm Thanks @danielvegamyhre ! |
--- | ||
layout: blog | ||
title: "Introducing JobSet" | ||
date: 2024-04-02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What publication date should we target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for 2015-01-10 - does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set publication date for 2025-01-13 since it was a few days til I had time to address these last comments, and want to give sufficient time for a final review.
Replicated Jobs | ||
: In modern data centers, hardware accelerators like GPUs and TPUs allocated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The headers look strange, should we move this line up and use a bold font for the header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is the right markdown
If the style doesn't look right: we'll take a PR (or you can file an issue).
@danielvegamyhre if you're comfortable rebasing, please rebase this against main; we've changed the site since this PR was first opened. |
See #45759 (comment) about the proposed publication date. |
@danielvegamyhre if you don't have time to address the remaining comments, I can take over the PR, please let me know. |
d3d0821
to
0ec6407
Compare
Thanks Daniel! /lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--- | ||
layout: blog | ||
title: "Introducing JobSet" | ||
date: 2024-01-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim we missed the date; what new date do you suggest we put here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry about that.
@danielvegamyhre can you add draft: true
into the front matter and a new future & weekday publication date? Then we can merge it as a draft and the process to fix things up is simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry about that.
@danielvegamyhre can you add
draft: true
into the front matter and a new future & weekday publication date? Then we can merge it as a draft and the process to fix things up is simpler.
Sure, done. I chose Feb 3rd this time to give us some breathing room.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs more work.
If you're not sure how to check it, try:
# assumes a clean working directory with no uncommited changes etc
git fetch <remote> pull/45759/head:pr-45759
git switch main
make container-image
git pull --ff-only
git switch -c pr-45759-merge-preview
git merge pr-45759 --no-ff
make container-serve
xdg-open http://localhost:1313/blog # might just be "open" not "xdg-open"
and then you should have a new browser window showing a preview. Most edits show up live. You need a container runtime like Docker or Podman; see the Makefile
for hints.
You can also do something similar on Windows, but we haven't yet documented how.
different names. | ||
|
||
<figure> | ||
<img src="jobset_diagram.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't render when I preview the article. I'm afraid that working images are a prerequisite for a merge.
Please consider using a figure short code with an alt
attribute set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would replacing this block with the following work?
{{< figure src="jobset_diagram.svg" alt="JobSet Architecture" class="diagram-large" clicktozoom="true" >}}
or
![JobSet Architecture](jobset_diagram.svg)
/lgtm cancel |
different names. | ||
|
||
<figure> | ||
<img src="jobset_diagram.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would replacing this block with the following work?
{{< figure src="jobset_diagram.svg" alt="JobSet Architecture" class="diagram-large" clicktozoom="true" >}}
or
![JobSet Architecture](jobset_diagram.svg)
<figure> | ||
<img src="jobset_diagram.svg"> | ||
<figcaption><h4>JobSet Architecture</h4></figcaption> | ||
</figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<figure> | |
<img src="jobset_diagram.svg"> | |
<figcaption><h4>JobSet Architecture</h4></figcaption> | |
</figure> | |
{{< figure src="jobset_diagram.svg" alt="JobSet Architecture" class="diagram-large" clicktozoom="true" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please just apply the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for someone to pick this up, but I really don't want to be the single load-bearing part in getting blog articles published. Because of how much I value distributing the work, I don't plan to do this step myself. @ahg-g you are welcome to ask other contributors to help out here.
We would like to publish a blog post introducing JobSet, a K8s native API for distributed ML training and HPC workloads.
cc @ahg-g @kannon92 I think we still need to align on one example and ideally make it more concrete and polished. We should also explain the user story above it.