Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow milestones in kubernetes/autoscaler #34086

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

adrianmoisey
Copy link
Member

@adrianmoisey adrianmoisey commented Jan 7, 2025

Allow sig-autoscaling-milestone-maintainers to manage milestones in kubernetes/autoscaler

Depends on kubernetes/org#5328

cc'ing @gjtempleton, who is the chair of sig-autoscaling

Note: I'm unsure if this is the correct process, please point me in the right direction if it is not

Allow sig-autoscaling-milestone-maintainers to manage milestones in
kubernetes/autoscaler
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 7, 2025
@gjtempleton
Copy link
Member

From the SIG Autoscaling side:
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@adrianmoisey
Copy link
Member Author

/assign wojtek-t

@dims
Copy link
Member

dims commented Jan 13, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit d527e92 into kubernetes:master Jan 13, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@adrianmoisey: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Allow sig-autoscaling-milestone-maintainers to manage milestones in kubernetes/autoscaler

Depends on kubernetes/org#5328

cc'ing @gjtempleton, who is the chair of sig-autoscaling

Note: I'm unsure if this is the correct process, please point me in the right direction if it is not

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants