-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ListTeamMembers with ListTeamMembersBySlug #29007
Replace ListTeamMembers with ListTeamMembersBySlug #29007
Conversation
Welcome @lanycrost! |
Hi @lanycrost. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This looks okay in general. nit: The solution suggested in #25600 (comment) to have the peribolos config contain the org AND team name would likely allow you to not have to introduce this new method (and multiple API calls for one function). This would also be a heavier lift though. |
@smg247 yeah, agree. It will be more accurate way, will do soon! |
I will dig in documentation to find more clean way |
@smg247 to avoid using of deprecated methods I suggest to use this method:
In that case I will do 3 requests in In this scenario we will not use any deprecated call. What you think about this? |
@chaodaiG What you think about above discussion? |
If the peribolos config contained the org and team name (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
for the typo in sig-node owned file
/retest-required |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lanycrost, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lanycrost: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hello @lanycrost, the Prow source code has been moved to https://github.com/kubernetes-sigs/prow on April 9, 2024. |
Hey, @jihoon-seo! OK, thank you! Will do it soon. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #27685
I've added the
GetTeamById
function to the codebase to ensure backward compatibility, and I'm not happy about it, if you can purpose more reliable workaround, I'll happy to do.If you have any plans to fully remove the deprecated functions, I'm fully supportive and ready to help.