Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding windows-hpc-base-image #3663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions images/windows-hpc-base/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
20 changes: 20 additions & 0 deletions images/windows-hpc-base/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# set default shell
SHELL=/bin/bash -o pipefail

REGISTRY ?= gcr.io/k8s-staging-build-image
IMG ?= windows-hpc-base-image
TAG ?= v1

.PHONY: clean
clean:
rm -rf build

.PHONY: image_build
image_build:
./build-hpc-base-image.sh

.PHONY: image_push
image_push: image_build
docker image import ./build/layer/layer.tar $(REGISTRY)/$(IMG):$(TAG)
echo "Pushing $(REGISTRY)/$(IMG):$(TAG)"
docker push $(REGISTRY)/$(IMG):$(TAG)
17 changes: 17 additions & 0 deletions images/windows-hpc-base/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Windows HostProcessContainer Base Image

This image can be used as the base image for Windows HostProcessContainer images and is based on https://github.com/microsoft/windows-host-process-containers-base-image/.

This image is built in and published to resources owned by the Kubernetes community so that other Kubernetes images can build upon it ant not rely on external resources such as the Microsoft Container Registry.

To build the image tarball:

```sh
make image_build
```

To publish the image to a registry:

```sh
REGISTRY=gcr.io/k8s-staging-releng VERSION=v0.1.0 make image_publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image image_publish target is missing from the makefile above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be image_push :-/ - i'll update

```
30 changes: 30 additions & 0 deletions images/windows-hpc-base/build-hpc-base-image.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/bin/bash
set -e

# Create a directory to build the image content in
rm -rf build
BUILD_DIR=build

#trap "rm -rf $BUILD_DIR" EXIT

# Create necessary sub-directorctories
mkdir -p "$BUILD_DIR/layer/Files/Windows/System32/config"

# Create the files that ProcessBaseLayer on Windows validates when unpacking container images
touch "$BUILD_DIR/layer/Files/Windows/System32/config/DEFAULT"
touch "$BUILD_DIR/layer/Files/Windows/System32/config/SAM"
touch "$BUILD_DIR/layer/Files/Windows/System32/config/SECURITY"
touch "$BUILD_DIR/layer/Files/Windows/System32/config/SOFTWARE"
touch "$BUILD_DIR/layer/Files/Windows/System32/config/SYSTEM"

# Add CC0 license to image
cp cc0-license.txt "$BUILD_DIR/layer/Files/License.txt"
cp cc0-legalcode.txt "$BUILD_DIR/layer/Files/cc0-legalcode.txt"

# Create layer.tar
echo "Creating $BUILD_DIR/layer/layer.tar"
cd "$BUILD_DIR/layer"
tar -cf layer.tar Files
cd - > /dev/null

exit
121 changes: 121 additions & 0 deletions images/windows-hpc-base/cc0-legalcode.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
Creative Commons Legal Code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just use the repo's ASLv2?

the resulting image on top of the base will be largely ASLv2 anyhow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equivalent image that gets published to MCR was released with the CC0 license - https://github.com/microsoft/windows-host-process-containers-base-image/blob/main/cc0-license.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we're going to build ASLv2 images with this, and CC0 is NOT on the CNCF approved list so we should not be using any CC0 images.

Are we using CC0 anywhere else ...?

https://github.com/cncf/foundation/blob/main/allowed-third-party-license-policy.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Copy link
Member

@puerco puerco Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also (I'm sure you saw mark) the script and Makefile need the boilerplate repo headers, and the automation will look for the apache license and fail if we use a different one.


CC0 1.0 Universal

CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES NOT PROVIDE
LEGAL SERVICES. DISTRIBUTION OF THIS DOCUMENT DOES NOT CREATE AN
ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS
INFORMATION ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO WARRANTIES
REGARDING THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS
PROVIDED HEREUNDER, AND DISCLAIMS LIABILITY FOR DAMAGES RESULTING FROM
THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS PROVIDED
HEREUNDER.

Statement of Purpose

The laws of most jurisdictions throughout the world automatically confer
exclusive Copyright and Related Rights (defined below) upon the creator
and subsequent owner(s) (each and all, an "owner") of an original work of
authorship and/or a database (each, a "Work").

Certain owners wish to permanently relinquish those rights to a Work for
the purpose of contributing to a commons of creative, cultural and
scientific works ("Commons") that the public can reliably and without fear
of later claims of infringement build upon, modify, incorporate in other
works, reuse and redistribute as freely as possible in any form whatsoever
and for any purposes, including without limitation commercial purposes.
These owners may contribute to the Commons to promote the ideal of a free
culture and the further production of creative, cultural and scientific
works, or to gain reputation or greater distribution for their Work in
part through the use and efforts of others.

For these and/or other purposes and motivations, and without any
expectation of additional consideration or compensation, the person
associating CC0 with a Work (the "Affirmer"), to the extent that he or she
is an owner of Copyright and Related Rights in the Work, voluntarily
elects to apply CC0 to the Work and publicly distribute the Work under its
terms, with knowledge of his or her Copyright and Related Rights in the
Work and the meaning and intended legal effect of CC0 on those rights.

1. Copyright and Related Rights. A Work made available under CC0 may be
protected by copyright and related or neighboring rights ("Copyright and
Related Rights"). Copyright and Related Rights include, but are not
limited to, the following:

i. the right to reproduce, adapt, distribute, perform, display,
communicate, and translate a Work;
ii. moral rights retained by the original author(s) and/or performer(s);
iii. publicity and privacy rights pertaining to a person's image or
likeness depicted in a Work;
iv. rights protecting against unfair competition in regards to a Work,
subject to the limitations in paragraph 4(a), below;
v. rights protecting the extraction, dissemination, use and reuse of data
in a Work;
vi. database rights (such as those arising under Directive 96/9/EC of the
European Parliament and of the Council of 11 March 1996 on the legal
protection of databases, and under any national implementation
thereof, including any amended or successor version of such
directive); and
vii. other similar, equivalent or corresponding rights throughout the
world based on applicable law or treaty, and any national
implementations thereof.

2. Waiver. To the greatest extent permitted by, but not in contravention
of, applicable law, Affirmer hereby overtly, fully, permanently,
irrevocably and unconditionally waives, abandons, and surrenders all of
Affirmer's Copyright and Related Rights and associated claims and causes
of action, whether now known or unknown (including existing as well as
future claims and causes of action), in the Work (i) in all territories
worldwide, (ii) for the maximum duration provided by applicable law or
treaty (including future time extensions), (iii) in any current or future
medium and for any number of copies, and (iv) for any purpose whatsoever,
including without limitation commercial, advertising or promotional
purposes (the "Waiver"). Affirmer makes the Waiver for the benefit of each
member of the public at large and to the detriment of Affirmer's heirs and
successors, fully intending that such Waiver shall not be subject to
revocation, rescission, cancellation, termination, or any other legal or
equitable action to disrupt the quiet enjoyment of the Work by the public
as contemplated by Affirmer's express Statement of Purpose.

3. Public License Fallback. Should any part of the Waiver for any reason
be judged legally invalid or ineffective under applicable law, then the
Waiver shall be preserved to the maximum extent permitted taking into
account Affirmer's express Statement of Purpose. In addition, to the
extent the Waiver is so judged Affirmer hereby grants to each affected
person a royalty-free, non transferable, non sublicensable, non exclusive,
irrevocable and unconditional license to exercise Affirmer's Copyright and
Related Rights in the Work (i) in all territories worldwide, (ii) for the
maximum duration provided by applicable law or treaty (including future
time extensions), (iii) in any current or future medium and for any number
of copies, and (iv) for any purpose whatsoever, including without
limitation commercial, advertising or promotional purposes (the
"License"). The License shall be deemed effective as of the date CC0 was
applied by Affirmer to the Work. Should any part of the License for any
reason be judged legally invalid or ineffective under applicable law, such
partial invalidity or ineffectiveness shall not invalidate the remainder
of the License, and in such case Affirmer hereby affirms that he or she
will not (i) exercise any of his or her remaining Copyright and Related
Rights in the Work or (ii) assert any associated claims and causes of
action with respect to the Work, in either case contrary to Affirmer's
express Statement of Purpose.

4. Limitations and Disclaimers.

a. No trademark or patent rights held by Affirmer are waived, abandoned,
surrendered, licensed or otherwise affected by this document.
b. Affirmer offers the Work as-is and makes no representations or
warranties of any kind concerning the Work, express, implied,
statutory or otherwise, including without limitation warranties of
title, merchantability, fitness for a particular purpose, non
infringement, or the absence of latent or other defects, accuracy, or
the present or absence of errors, whether or not discoverable, all to
the greatest extent permissible under applicable law.
c. Affirmer disclaims responsibility for clearing rights of other persons
that may apply to the Work or any use thereof, including without
limitation any person's Copyright and Related Rights in the Work.
Further, Affirmer disclaims responsibility for obtaining any necessary
consents, permissions or other rights required for any use of the
Work.
d. Affirmer understands and acknowledges that Creative Commons is not a
party to this document and has no duty or obligation with respect to
this CC0 or use of the Work.
8 changes: 8 additions & 0 deletions images/windows-hpc-base/cc0-license.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Windows-host-process-containers-base-image by Microsoft Corporation.

To the extent possible under law, the persons who associated CC0 with
Windows-host-process-containers-base-image has waived all copyright
and related or neighboring rights to this work.

You should have received a copy of the CC0 legalcode along with this
work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.
16 changes: 16 additions & 0 deletions images/windows-hpc-base/cloudbuild.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# See https://cloud.google.com/cloud-build/docs/build-configCloudBu
timeout: 1200s
options:
substitution_option: ALLOW_LOOSE
steps:
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20230522-312425ae46'
entrypoint: bash
env:
- DOCKER_CLI_EXPERIMENTAL=enabled
- HOME/root
args:
- '-c'
- |
gcloud auth configure-docker
make image_build
make image_push