Avoid parent process if no log redirection is used

Exec the command without forking in case go-runner does not need to perform log output redirection. Signed-off-by: Marc Hoersken <[email protected]>
kubernetes · May 23, 2024 · 2e7e2d8 · 2e7e2d8
1 parent f294861
commit 2e7e2d8
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/images/build/go-runner/go-runner.go b/images/build/go-runner/go-runner.go
@@ -46,6 +46,7 @@ func configureAndRun() error {
 	var (
 		outputStream io.Writer = os.Stdout
 		errStream    io.Writer = os.Stderr
+		err          error
 	)
 
 	args := flag.Args()
@@ -79,7 +80,11 @@ func configureAndRun() error {
 	cmd.Stderr = errStream
 
 	log.Printf("Running command:\n%v", cmdInfo(cmd))
-	err := cmd.Start()
+	if cmd.Stdout == os.Stdout && cmd.Stderr == os.Stderr {
+		err = syscall.Exec(cmd.Path, cmd.Args, syscall.Environ())
+	} else {
+		err = cmd.Start()
+	}
 	if err != nil {
 		return fmt.Errorf("starting command: %w", err)
 	}