Rename AKS provider to Azure

[Jont828]

/kind feature

What type of PR is this?

What this PR does / why we need it: Rename the AKS provider to Azure since it works with non-AKS Azure clusters (such as CAPZ) as well.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

[mboersma]

Could you also update the README for CL2 to mention azure as an option for provider?

[jackfrancis]

cc @JohnRusk

Do you have any thoughts on this change?

[JohnRusk]

I think the stated rationale makes sense.

The only risk I can think of would be if in fact this statement wasn't always correct: "since it works with non-AKS Azure clusters (such as CAPZ) as well". I.e. if in fact there are expected to be any kind of Azure cluster that it does not support - is that a problem? E.g. does it create an implied mainteance burden to modify this so that it does support them?

But I think my concern there is very minor, and unlikely to any reason to reject the PR. So, if you're happy with it as it stands, so am I @jackfrancis .

[jackfrancis]

The only risk I can think of would be if in fact this statement wasn't always correct: "since it works with non-AKS Azure clusters (such as CAPZ) as well". I.e. if in fact there are expected to be any kind of Azure cluster that it does not support - is that a problem? E.g. does it create an implied mainteance burden to modify this so that it does support them?

I think that is a valid point, and I would argue that if we discover this to be true in the future (novel Kubernetes + Azure infra use case) that the provider doesn't support, we want to support it. I'm committed to that level of support.

[JohnRusk]

Sounds good to me @jackfrancis

[mboersma]

lgtm, but needs a rebase.

[mboersma]

@Jont828 this needs to be rebased.

[Jont828]

@mboersma Done!

[mboersma]

/lgtm

[Jont828]

@mboersma Just rebased it, shouldn't have changed anything.

[mboersma]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jont828, mboersma
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• clusterloader2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.