Add deletePodsOp to scheduler_perf #127471
Conversation
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
k8s-ci-robot
added
area/test
sig/testing
| // Namespace the pods should be deleted from. | ||
| Namespace string | ||
| // Labels used to filter the pods to delete. | ||
| Labels map[string]string |
There was a problem hiding this comment.
Actually, in which case will we need label selector? (isn't Namespace enough?)
If you're going to use it to delete Pods created by multiple createPodsOp, you need to mark Namespace as optional.
There was a problem hiding this comment.
Topology spreading plugin works only within a single namespace. We'll need the unschedulable pods blocked by topology spreading to be is the same namespace as the blocker pods that we'll need to delete.
macsko
force-pushed
the
add_deletepodsop_to_scheduler_perf
branch
from
3dbeb07
to
78ec902
Compare
k8s-ci-robot
added
size/L
| @@ -1333,7 +1333,10 @@ | |||
| # Create pods that will be gradually deleted after being scheduled. | |||
| - opcode: createPods | |||
| countParam: $deletingPods | |||
| - opcode: deletePods | |||
There was a problem hiding this comment.
can you improve the description of the test to give some high level idea of the intermediate steps?
k8s-ci-robot
added
the
approved
There was a problem hiding this comment.
/lgtm
/hold
for the last comment from Aldo https://github.com/kubernetes/kubernetes/pull/127471/files#r1767326718
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0174756e1c166181a28e5fbf2921b01e25031df6
|
macsko
force-pushed
the
add_deletepodsop_to_scheduler_perf
branch
from
78ec902
to
287b619
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
lgtm
|
LGTM label has been added. Git tree hash: 2b1ebc1260d7a48848716862805350e3e3fa8c06
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, macsko, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We need to be able to begin pod deletion a bit later, especially for queueing hint performance tests. That's why a separate op seems reasonable.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: