fix: de-duplication of custom resource metrics

[bartlettc22]

What this PR does / why we need it:
Fixes an issue that causes custom resource metrics to duplicate every time a CR resource that KSM is watching changed. The duplication was happening because the informer events (add/delete) triggered a subsequent call to WithEnabledResources in store.Builder. This would append, but not de-duplicate the CR resources to the enabledResources list. This, in turn, would cause the custom resources to be be added multiple times when the store was built.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change cardinality

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2446

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mrueg / name: Manuel Rüger (bd6beed)
• ✅ login: bartlettc22 / name: Chris Bartlett (de58db2, 24c2194)

[k8s-ci-robot]

Welcome @bartlettc22!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[dgrisonnet]

/assign @rexagod
/triage accepted

[rexagod]

Requested a minor change below. Thank you for the much needed patch!

[bartlettc22]

Requested a minor change below. Thank you for the much needed patch!

@rexagod updated - thanks for the suggestion!

[mrueg]

/lgtm

/hold
for others to review

[mrueg]

/hold cancel
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartlettc22, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment