-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customresourcestate: don't error on missing status stateSet #2483
base: main
Are you sure you want to change the base?
Conversation
It's legitimate for new objects to not have status fields. Especially if controller is unavailable. Such errors are printed for every resource and can mask actual problems. Instead, log in verbose mode to allow troubleshooting. Fixes kubernetes#2482
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @roeoo! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: roeoo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It's legitimate for new objects to not have status fields. Especially if controller is unavailable. Such errors are printed for every resource and can mask actual problems. Instead, log in verbose mode to allow troubleshooting.
Fixes #2482
What this PR does / why we need it:
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #