Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Ubuntu 24.04 to stable in Kops 1.31 #17192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote Ubuntu 24.04 to stable in Kops 1.31 #17192

wants to merge 1 commit into from
+4 −2

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jan 9, 2025

/hold for feedback

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman January 9, 2025 02:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@hakman
Copy link
Member

hakman commented Jan 9, 2025 •
edited
Loading

@rifelpet I would go with 1.32. kOps 1.31 is already planned for release soon.

@ameukam
Copy link
Member

ameukam commented Jan 9, 2025

One possible impact would be cgroups detection. IIRC Ubuntu 24.04 is only cgroups v2.

@hakman
Copy link
Member

hakman commented Jan 9, 2025

One possible impact would be cgroups detection. IIRC Ubuntu 24.04 is only cgroups v2.

That's why we waited so long to move to Ubuntu 24.04. 😁

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2025
hakman
hakman reviewed Jan 12, 2025
View reviewed changes
docs/operations/images.md
@@ -268,7 +268,9 @@ az vm image list --all --output table \

### Ubuntu 24.04 (Noble)

Support for Ubuntu 24.04 is **experimental**.
Support for Ubuntu 24.04 is based on Kernel version **6.8**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Support for Ubuntu 24.04 is based on Kernel version **6.8**.
Support for Ubuntu 24.04 is based on Kernel version **6.8**.
**WARNING**: The Amazon VPC CNI is not compatible with Ubuntu 24.04.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a github issue we can link to? I'm not finding one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of, I just remember it now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rifelpet @hakman @ameukam @k8s-ci-robot