Instance Group Manager does not remove nodes with empty string in the zone field #2658

08volt · 2024-09-03T08:12:20Z

Updates Instance Group Manager to Support Nodes with Empty Zones

Bug:

The Load Balancer controller removes nodes with an empty string in the Zone field, even when they are already in the correct instance group.

Solution:

Prevents the removal of nodes with an empty string in the Zone field.

Details:

Nodes can have an empty Zone if it hasn't been assigned yet.
The Zone was previously retrieved from the providerID using a regular expression (var providerIDRE = regexp.MustCompile(^+ "gce" +://([^/]+)/([^/]+)/([^/]+)$)) that didn't account for empty Zones, leading to errors.
The regular expression has been updated to: var providerIDRE = regexp.MustCompile(^+ "gce" +://([^/]+)/([^/]*)/([^/]+)$) to support empty Zones.
Instances where the code checked for errors have been updated to also handle empty Zones.
The Instance Group Manager has been updated to not remove nodes without an assigned Zone.

k8s-ci-robot · 2024-09-03T08:12:29Z

Hi @08volt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

08volt · 2024-09-03T08:47:25Z

@cezarygerard

cezarygerard · 2024-09-03T15:25:09Z

/lgtm

cezarygerard · 2024-09-03T15:25:15Z

/hold

cezarygerard · 2024-09-03T15:25:28Z

/ok-to-test

cezarygerard · 2024-09-03T15:26:17Z

my lgtm was accidental, for now

pkg/instancegroups/manager.go

pkg/utils/zonegetter/zone_getter.go

pkg/instancegroups/manager.go

pkg/utils/zonegetter/zone_getter.go

pkg/instancegroups/manager_test.go

Nodes can have empty zone if it not has been assigned yet. The zone was retrieved from providerID using the following Regular Expression Matching and taking the second match: ```var providerIDRE = regexp.MustCompile(`^` + "gce" + `://([^/]+)/([^/]+)/([^/]+)$`)``` In the case of empty zone it was generating an Error. In order to allow an empty zone to match the Regular Expression, it has been updated to: ```var providerIDRE = regexp.MustCompile(`^` + "gce" + `://([^/]+)/([^/]*)/([^/]+)$`)``` After that, I updated all the instances where the code was checking the error, to check also for the empty zone. I updated the Instance Group Manager to not remove the nodes which do not have a zone assigned.

mmamczur · 2024-10-29T14:15:20Z

/lgtm

k8s-ci-robot · 2024-10-29T14:15:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 08volt, cezarygerard, mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cezarygerard,mmamczur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mmamczur · 2024-10-31T10:48:08Z

/unhold

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 3, 2024

k8s-ci-robot requested review from gauravkghildiyal and sawsa307 September 3, 2024 08:12

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2024

k8s-ci-robot assigned cezarygerard Sep 3, 2024

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 3, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2024

cezarygerard reviewed Sep 4, 2024

View reviewed changes

pkg/instancegroups/manager.go Show resolved Hide resolved

pkg/utils/zonegetter/zone_getter.go Show resolved Hide resolved

08volt force-pushed the empty-zones branch 3 times, most recently from 1f151d8 to 726a46f Compare September 4, 2024 12:55

cezarygerard reviewed Sep 4, 2024

View reviewed changes

pkg/instancegroups/manager.go Outdated Show resolved Hide resolved

pkg/instancegroups/manager.go Outdated Show resolved Hide resolved

pkg/utils/zonegetter/zone_getter.go Outdated Show resolved Hide resolved

08volt force-pushed the empty-zones branch 2 times, most recently from fb05798 to 0b2fcc6 Compare September 4, 2024 14:29

mmamczur reviewed Sep 6, 2024

View reviewed changes