Skip to content

Commit

Permalink
add PRR approval request file and filled out PRR questionnaire just f…
Browse files Browse the repository at this point in the history
…or alpha relevant sections.
  • Loading branch information
everpeace committed Feb 9, 2023
1 parent ba195b6 commit b598ea5
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 3 deletions.
6 changes: 6 additions & 0 deletions keps/prod-readiness/sig-node/3619.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# The KEP must have an approver from the
# "prod-readiness-approvers" group
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
kep-number: 3619
alpha:
approver: "@johnbelamaric"
25 changes: 22 additions & 3 deletions keps/sig-node/3619-supplemental-groups-policy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -671,9 +671,9 @@ well as the [existing list] of feature gates.
[existing list]: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
-->

- [ ] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name:
- Components depending on the feature gate:
- [x] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name: SupplementalGroupsPolicy
- Components depending on the feature gate: kube-apiserver, kubelet, (and CRI implementations(e.g. containerd, cri-o))
- [ ] Other
- Describe the mechanism:
- Will enabling / disabling the feature require downtime of the control
Expand All @@ -687,6 +687,7 @@ well as the [existing list] of feature gates.
Any change of default behavior may be surprising to users or break existing
automations, so be extremely careful here.
-->
No. Just introducing new API fields in Pod spec and CRI which does NOT change the default behavior.

###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?

Expand All @@ -701,8 +702,12 @@ feature.
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
-->

Yes. It can be disabled after enabled. However, users should pay attention that gids of container processes in pods with `IgnoreGroupsInImage` policy would change. It means the action might break the application in permission. We plan to provide a way for users to detect which pods are affected.

###### What happens if we reenable the feature if it was previously rolled back?

Just the policy `IgnoreGroupsInImage` is reenabled. Users should pay attention that gids of containers in pods with `IgnoreGroupsInImage` policy would change. It means that the action might break the application in permission. We plan to provide a way for users to detect which pods are affected.

###### Are there any tests for feature enablement/disablement?

<!--
Expand All @@ -718,6 +723,8 @@ You can take a look at one potential example of such test in:
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
-->

Planned for Alpha.

### Rollout, Upgrade and Rollback Planning

<!--
Expand Down Expand Up @@ -880,6 +887,8 @@ Focusing mostly on:
heartbeats, leader election, etc.)
-->

No. Just introducing new API fields in Pod spec and CRI which does NOT change the default behavior.

###### Will enabling / using this feature result in introducing new API types?

<!--
Expand All @@ -889,6 +898,8 @@ Describe them, providing:
- Supported number of objects per namespace (for namespace-scoped objects)
-->

No.

###### Will enabling / using this feature result in any new calls to the cloud provider?

<!--
Expand All @@ -897,6 +908,8 @@ Describe them, providing:
- Estimated increase:
-->

No.

###### Will enabling / using this feature result in increasing size or count of the existing API objects?

<!--
Expand All @@ -906,6 +919,8 @@ Describe them, providing:
- Estimated amount of new objects: (e.g., new Object X for every existing Pod)
-->

No.

###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?

<!--
Expand All @@ -917,6 +932,8 @@ Think about adding additional work or introducing new steps in between
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
-->

No.

###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?

<!--
Expand All @@ -929,6 +946,8 @@ This through this both in small and large cases, again with respect to the
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
-->

No.

### Troubleshooting

<!--
Expand Down

0 comments on commit b598ea5

Please sign in to comment.