-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix e2e #7664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e #7664
Conversation
/hold |
Codecov Report
@@ Coverage Diff @@
## master #7664 +/- ##
=======================================
Coverage 42.19% 42.19%
=======================================
Files 218 218
Lines 12099 12099
Branches 180 180
=======================================
Hits 5105 5105
Misses 6709 6709
Partials 285 285 |
@shu-mutou Tests are being skipped on master right now. To test it remove the if from workflow definition. |
We have not upgraded cypress for a while, and there have been some breaking changes in the meantime. And I'm not used to cypress, so it's going to take some time. But I'll try to tackle to this. |
f11513f
to
127e992
Compare
The work is not finished, but since it is dinner, I will continue tomorrow. 😉 |
I could run e2e test in my environment partially. I've got error on running |
Bumped some related componens to latest. But not finished yet. |
Found same workarround. |
Because cypress does not seem to support ES2022.
I tryed to update |
|
And set interval for |
Also, |
I can see good progress, thanks @shu-mutou for taking care of it. |
Because it still outputs about 200 lines of useless log during starting up dashboard.
I finally did it! 🎉 |
/hold cancel |
Great, now we will need to ensure tests will stay healthy. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
At first, bump cypress from 9.7.0 to 10.0.0