Skip to content

Fix e2e #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 28, 2023
Merged

Fix e2e #7664

merged 22 commits into from
Mar 28, 2023

Conversation

shu-mutou
Copy link
Contributor

At first, bump cypress from 9.7.0 to 10.0.0

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2023
@shu-mutou
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #7664 (9deee04) into master (cbbc452) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7664   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files         218      218           
  Lines       12099    12099           
  Branches      180      180           
=======================================
  Hits         5105     5105           
  Misses       6709     6709           
  Partials      285      285           

@maciaszczykm
Copy link
Member

maciaszczykm commented Mar 16, 2023

@shu-mutou Tests are being skipped on master right now. To test it remove the if from workflow definition.

@shu-mutou
Copy link
Contributor Author

We have not upgraded cypress for a while, and there have been some breaking changes in the meantime. And I'm not used to cypress, so it's going to take some time. But I'll try to tackle to this.

@shu-mutou shu-mutou force-pushed the fix-e2e branch 4 times, most recently from f11513f to 127e992 Compare March 22, 2023 09:28
@shu-mutou
Copy link
Contributor Author

angular live development server does not seem to proxy properly...

Screenshot from 2023-03-22 18-38-21

@shu-mutou
Copy link
Contributor Author

The work is not finished, but since it is dinner, I will continue tomorrow. 😉

@shu-mutou
Copy link
Contributor Author

I could run e2e test in my environment partially. I've got error on running nav.cy.ts but not userpanel.cy.ts. See you next.

@shu-mutou
Copy link
Contributor Author

Screenshot from 2023-03-22 19-09-33
Screenshot from 2023-03-22 19-09-53

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2023
@shu-mutou
Copy link
Contributor Author

Bumped some related componens to latest. But not finished yet.

@shu-mutou
Copy link
Contributor Author

Screenshot from 2023-03-22 19-09-33

These compilation errors seems to be caused by "target": "ES2022"in tsconfig.json. If change this to"ES2021"`, these compilation errors are disappeared.
But it's not good idea to fallback to "ES2021", I think.... So investigating more..

@shu-mutou
Copy link
Contributor Author

Found same workarround.
cypress-io/cypress#25300 (comment)

Because cypress does not seem to support ES2022.
@shu-mutou
Copy link
Contributor Author

I tryed to update typescript to latest 5.0.2, but latest angular staff 15.2.4 does not support it.

@shu-mutou
Copy link
Contributor Author

shu-mutou commented Mar 24, 2023

localhost in proxy.conf.json for development server works in my development environment, but it does not seem to work in CI. 🤔

@shu-mutou
Copy link
Contributor Author

And set interval for wait-on to 5sec, to prevent generating tons of logs during start up dashboard.

@shu-mutou
Copy link
Contributor Author

Also, localhost for wait-on in package.json does not work in CI.... 😕
Finally development server and cypress work now!! 🎉
But fixing test code is needed yet.

@maciaszczykm
Copy link
Member

I can see good progress, thanks @shu-mutou for taking care of it.

Because it still outputs about 200 lines of useless log during starting up dashboard.
@shu-mutou
Copy link
Contributor Author

I finally did it! 🎉

@shu-mutou
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2023
@maciaszczykm
Copy link
Member

Great, now we will need to ensure tests will stay healthy.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maciaszczykm,shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d650d38 into kubernetes:master Mar 28, 2023
@shu-mutou shu-mutou deleted the fix-e2e branch March 29, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants