Fix IPAddressVisibility type

The const is missleading and valid value is External and Private.
kubernetes · Aug 22, 2024 · bdc1c25 · bdc1c25
1 parent 2df9cac
commit bdc1c25
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/pkg/cloudprovider/vsphereparavirtual/nsxipmanager/nsx_vpc.go b/pkg/cloudprovider/vsphereparavirtual/nsxipmanager/nsx_vpc.go
@@ -77,12 +77,12 @@ func (m *NSXVPCIPManager) ReleasePodCIDR(node *corev1.Node) error {
 }
 
 // convertToIPAddressVisibility converts the ip pool type to the ip address visibility. This is needed because the nsx
-// does not unify names yet. Public equals to External. TODO: remove this once nsx unifies names.
+// does not unify names yet. Public equals to External.
 func convertToIPAddressVisibility(ipPoolType string) vpcapisv1.IPAddressVisibility {
 	if ipPoolType == PublicIPPoolType {
-		return vpcapisv1.IPAddressVisibilityExternal
+		return "External"
 	}
-	return vpcapisv1.IPAddressVisibilityPrivate
+	return "Private"
 }
 
 // NewNSXVPCIPManager returns a new NSXVPCIPManager object.

diff --git a/pkg/cloudprovider/vsphereparavirtual/nsxipmanager/nsx_vpc_test.go b/pkg/cloudprovider/vsphereparavirtual/nsxipmanager/nsx_vpc_test.go
@@ -124,7 +124,7 @@ func TestNSXVPCIPManager_ClaimPodCIDR(t *testing.T) {
 							},
 						},
 						Spec: vpcapisv1.IPAddressAllocationSpec{
-							IPAddressBlockVisibility: vpcapisv1.IPAddressVisibilityExternal,
+							IPAddressBlockVisibility: "External",
 							AllocationSize:           allocationSize,
 						},
 					},
@@ -149,7 +149,7 @@ func TestNSXVPCIPManager_ClaimPodCIDR(t *testing.T) {
 							},
 						},
 						Spec: vpcapisv1.IPAddressAllocationSpec{
-							IPAddressBlockVisibility: vpcapisv1.IPAddressVisibilityPrivate,
+							IPAddressBlockVisibility: "Private",
 							AllocationSize:           allocationSize,
 						},
 					},
@@ -180,7 +180,7 @@ func TestNSXVPCIPManager_ClaimPodCIDR(t *testing.T) {
 							},
 						},
 						Spec: vpcapisv1.IPAddressAllocationSpec{
-							IPAddressBlockVisibility: vpcapisv1.IPAddressVisibilityPrivate,
+							IPAddressBlockVisibility: "Private",
 							AllocationSize:           allocationSize,
 						},
 					},
@@ -213,7 +213,7 @@ func TestNSXVPCIPManager_ClaimPodCIDR(t *testing.T) {
 						},
 					},
 					Spec: vpcapisv1.IPAddressAllocationSpec{
-						IPAddressBlockVisibility: vpcapisv1.IPAddressVisibilityPrivate,
+						IPAddressBlockVisibility: "Private",
 						AllocationSize:           allocationSize,
 					},
 				},
@@ -260,7 +260,7 @@ func TestNSXVPCIPManager_ReleasePodCIDR(t *testing.T) {
 			Namespace: ns,
 		},
 		Spec: vpcapisv1.IPAddressAllocationSpec{
-			IPAddressBlockVisibility: vpcapisv1.IPAddressVisibilityExternal,
+			IPAddressBlockVisibility: "External",
 			AllocationSize:           allocationSize,
 		},
 	}