Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all]refactory metrics code so that additional code can consume it #1236

Merged
merged 1 commit into from
Jan 29, 2021
Merged

[all]refactory metrics code so that additional code can consume it #1236

merged 1 commit into from
Jan 29, 2021

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

refactory metrics code so that #913 might consume it

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2020
@jichenjc
Copy link
Contributor Author

@seanschneeweiss any suggestions?

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build failed.

@seanschneeweiss seanschneeweiss mentioned this pull request Sep 24, 2020
Merged
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build succeeded.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 29, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 29, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 29, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

@ramineni I used my local build image and tested ,seems works fine

# k describe daemonset openstack-cloud-controller-manager -n kube-system | grep Image:
    Image:      jichenjc/openstack-cloud-controller-manager-amd64

# curl -k https://localhost:10258/metrics
# HELP apiserver_audit_event_total [ALPHA] Counter of audit events generated and sent to the audit backend.
# TYPE apiserver_audit_event_total counter
apiserver_audit_event_total 0
# HELP apiserver_audit_requests_rejected_total [ALPHA] Counter of apiserver requests rejected due to an error in audit logging backend.
# TYPE apiserver_audit_requests_rejected_total counter
apiserver_audit_requests_rejected_total 0
# HELP apiserver_client_certificate_expiration_seconds [ALPHA] Distribution of the remaining lifetime on the certificate used to authenticate a request.
# TYPE apiserver_client_certificate_expiration_seconds histogram
apiserver_client_certificate_expiration_seconds_bucket{le="0"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="1800"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="3600"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="7200"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="21600"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="43200"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="86400"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="172800"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="345600"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="604800"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="2.592e+06"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="7.776e+06"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="1.5552e+07"} 0
apiserver_client_certificate_expiration_seconds_bucket{le="3.1104e+07"} 0

@jichenjc
Copy link
Contributor Author

@ramineni @lingxiankong please help to review, thanks

@ramineni
Copy link
Contributor

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
seanschneeweiss
seanschneeweiss suggested changes Jan 20, 2021
View reviewed changes
pkg/metrics/metrics_api.go Outdated
}
)

// ObserveReconcile records the request latency and counts the errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ObserveReconcile records the request latency and counts the errors.
// ObserveRequest records the request latency and counts the errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pkg/metrics/metrics_reconcile.go Outdated
}
)

// ObserveReconcile records the request latency and counts the errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ObserveReconcile records the request latency and counts the errors.
// ObserveReconcile records reconciliation duration,
// frequency and number of errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

@lingxiankong @seanschneeweiss @ramineni can you take another look? thanks

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@lingxiankong
Copy link
Contributor

/approve

Thanks for picking up this refactoring work!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit c700948 into kubernetes:master Jan 29, 2021
@jichenjc jichenjc mentioned this pull request Feb 2, 2021
Closed
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@jichenjc
refactory metrics code so that additional code can consume it (kubern…
07db012 
…etes#1236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong lingxiankong left review comments

@seanschneeweiss seanschneeweiss seanschneeweiss requested changes

@ramineni ramineni ramineni requested changes

@anguslees anguslees Awaiting requested review from anguslees

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jichenjc @lingxiankong @ramineni @k8s-ci-robot @seanschneeweiss