Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubeVersion string to validate GKE clusters #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix kubeVersion string to validate GKE clusters #81

wants to merge 2 commits into from

Conversation

dargudear-google
Copy link

Fixes: #80

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dargudear-google
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dargudear-google!

It looks like this is your first PR to kubernetes-sigs/secrets-store-sync-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-sync-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2024
@nilekhc
Copy link
Contributor

nilekhc commented Sep 12, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2024
@nilekhc
Copy link
Contributor

nilekhc commented Sep 12, 2024

/test pull-secrets-store-sync-controller-lint

@nilekhc nilekhc mentioned this pull request Sep 13, 2024
Merged
3 tasks
@nilekhc
Copy link
Contributor

nilekhc commented Sep 13, 2024

@dargudear-google: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-sync-controller-image-scan dcf8cab link false /test pull-secrets-store-sync-controller-image-scan
pull-secrets-store-sync-controller-lint dcf8cab link true /test pull-secrets-store-sync-controller-lint
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Fixed by #85

@nilekhc
Copy link
Contributor

nilekhc commented Sep 13, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2024
@dargudear-google
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2024
@dargudear-google
Copy link
Author

/retest-required

@dargudear-google
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2024 •
edited
Loading

@dargudear-google: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-sync-controller-e2e-provider-k8s-1-27-15 ae21b0c link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-27-15
pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-11 ae21b0c link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-11
pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-6 ae21b0c link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-6
pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-2 ae21b0c link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dargudear-google
Copy link
Author

/retest

@nilekhc
Copy link
Contributor

nilekhc commented Sep 30, 2024

/retest

@nilekhc
Copy link
Contributor

nilekhc commented Oct 7, 2024

/retest-required

@nilekhc
Copy link
Contributor

nilekhc commented Oct 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@nilekhc
Copy link
Contributor

nilekhc commented Oct 7, 2024

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
benjaminapetersen
benjaminapetersen reviewed Oct 17, 2024
View reviewed changes
manifest_staging/charts/secrets-store-sync-controller/Chart.yaml
@@ -2,5 +2,5 @@ apiVersion: v2
name: secrets-store-sync-controller
version: 0.0.1
appVersion: v0.0.1
kubeVersion: ">=1.27.0"
kubeVersion: ">=1.27.0-0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd the -0 is what fixes this. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

@enj enj Awaiting requested review from enj

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees

@nilekhc nilekhc

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm install does not work with GKE.
4 participants
@dargudear-google @k8s-ci-robot @nilekhc @benjaminapetersen