Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix: remaining Go upgrades #4470

Merged
merged 1 commit into from
Jan 6, 2025
Merged

🌱 fix: remaining Go upgrades #4470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-devcontainer.yaml → .github/workflows/test-devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup Go 1.22.x
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Please see https://git.k8s.io/community/CLA.md for more info.

## Prerequisites

- [go](https://golang.org/dl/) version v1.22+.
- [go](https://golang.org/dl/) version v1.23+.
- [docker](https://docs.docker.com/install/) version 17.03+.
- [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version v1.11.3+.
- [kustomize](https://github.com/kubernetes-sigs/kustomize/blob/master/site/content/en/docs/Getting%20started/installation.md) v3.1.0+
Expand Down
4 changes: 2 additions & 2 deletions docs/book/book.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ command = "./litgo.sh"
command = "./markerdocs.sh"

[context.environment]
environment = { GO_VERSION = "1.22" }
environment = { GO_VERSION = "1.23" }

[context.deploy-preview.environment]
environment = { GO_VERSION = "1.22" }
environment = { GO_VERSION = "1.23" }

2 changes: 1 addition & 1 deletion docs/book/src/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This Quick Start guide will cover:

## Prerequisites

- [go](https://go.dev/dl/) version v1.22.0+
- [go](https://go.dev/dl/) version v1.23.0+
- [docker](https://docs.docker.com/install/) version 17.03+.
- [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version v1.11.3+.
- Access to a Kubernetes v1.11.3+ cluster.
Expand Down
4 changes: 2 additions & 2 deletions docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module v1

go 1.22.0
go 1.23.0

toolchain go1.22.5
godebug default=go1.23

require (
github.com/spf13/pflag v1.0.5
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build]
base = "docs/book"
command = "GO_VERSION=1.22.0 ./install-and-build.sh"
command = "GO_VERSION=1.23.0 ./install-and-build.sh"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Does this not read env from docs/book/book.toml?

publish = "docs/book/book"
functions = "docs/book/functions"

Expand Down
Loading