-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix compatibility issues encountered while setting up envtest by using the controller-runtime branch releases (unblock CI) #3824
🐛 Fix compatibility issues encountered while setting up envtest by using the controller-runtime branch releases (unblock CI) #3824
Conversation
8ed0a10
to
1e312bc
Compare
1e312bc
to
94eb3fb
Compare
713a0b8
to
2dc2f6d
Compare
8884bfe
to
05bcc0a
Compare
ef9e5b9
to
8517398
Compare
905ef57
to
dacdc02
Compare
…time release and we no longer support go/v2 version
dacdc02
to
c2306f8
Compare
I will be a little :cowboy: here and get this one merged for we unblock our CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good to me. I'm switching to the envtest setup issue now. |
Description
This pull request addresses issues encountered after
controller-runtime
updated to Go version 1.22, which resulted in failing tests due to issues with installingenvtest
binaries. For additional context, please refer to this issue.To resolve these challenges, the PR implements the following fixes:
Use of Release Branch: Instead of installing the latest version, this PR changes the approach to use the specific release branch. While pinning to a tag version would be ideal for ensuring compatibility, it's currently not feasible. Therefore, utilizing the release branch is the most technically viable solution to guarantee compatibility.
Manual Sample Update for
make generate
: Themake generate
target generates all samples documented except for the multi-version one. Given the necessity to proceed with the fixes, this PR includes manual updates to the outdated multi-version sample. The updates are necessary due to the discrepancies highlighted by the issues addressed in this PR, and are meticulously detailed in the commit history.Removal of Legacy Tests for
go/v2
: As part of a strategic move towards releasing a MAJOR version update of Kubebuilder, this PR removes legacy tests related togo/v2
. The rationale is to focus on forward compatibility rather than expending efforts on outdated versions. This aligns with our broader objectives of streamlining the development process and ensuring up-to-date compliance with current standards.The changes proposed in this PR are crucial for maintaining the integrity and functionality of the project, especially in light of the recent Go version update in
controller-runtime
. By addressing these issues promptly, we aim to minimize disruptions and ensure a smooth development experience for contributors and users alike.