Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release krew 0.4.4 #3250

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Release krew 0.4.4 #3250

merged 4 commits into from
Jul 14, 2023

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jul 14, 2023

It's been a while.

@ahmetb
Copy link
Member Author

ahmetb commented Jul 14, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/krew.yaml is not a straightforward version bump: change on line 3 does not seem like a version bump: [+ # The supported platforms for plugins are the ones that Krew itself is distributed in.]
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins labels Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2023
@chriskim06
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@chriskim06
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit a0a7f32 into kubernetes-sigs:master Jul 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@chriskim06 chriskim06

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmetb @k8s-ci-robot @chriskim06