Fix: update wait command for nginx ingress setup #3773
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the wait command in the nginx ingress setup documentation to address timing issues on slower systems. The original documentation suggested waiting for the ingress controller pod readiness, but did not account for the time required for ingress-nginx-admission-patch and ingress-nginx-admission-create jobs to complete, especially on slower networks or systems.
Changes:
1.)Added a command to wait for the ingress-nginx-admission-patch job to complete before checking the readiness of the ingress controller.
2.)Updated command sequence:
kubectl wait --namespace ingress-nginx
--for=condition=complete job/ingress-nginx-admission-patch
--timeout=30s
&&
kubectl wait --namespace ingress-nginx
--for=condition=ready pod
--selector=app.kubernetes.io/component=controller
--timeout=90s
This improvement will prevent premature command errors (such as no matching resources found) by ensuring the patch job has completed before readiness is checked.
Issue Reference: Resolves #2293