expose advanced packer googlecompute auth options to users

[itspngu]

What this PR does / why we need it:

Exposes some more of the knobs that come with the googlecompute packer builder.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #941

Additional context
I'd have liked to make some more settings configurable, such as those related to iap and oslogin, but as far as I can tell that's not possible with the JSON format (if it is, please do point me in the right direction so I can add that) and thus blocked-ish by #814

The choice of GOOGLE_IMPERSONATE_SERVICE_ACCOUNT as an environment variable name is in line with what the Terraform does but not a standard for Google tooling (though I wish it was... x)) and can be removed or renamed if needed.

[k8s-ci-robot]

Hi @itspngu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itspngu
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• images/capi/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[itspngu]

I'm starting to think that this PR might not be the way to do it, there's too many loose ends. There were some interesting changes to the googlecompute builder that aren't part of any packer release yet (https://github.com/hashicorp/packer-plugin-googlecompute/releases/tag/v1.0.14), the used version of packer itself is one minor version behind upstream, and the (pending?) migration from JSON to HCL for the configuration files would bring its own benefits. Thoughts?

[k8s-ci-robot]

@itspngu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kkeshavamurthy]

@itspngu any updates on this?

Regarding migration from json to hcl, we have a lot of upstream and downstream pipelines tinkering the json files. Even though the process of conversion to HCL is easy, it'll break a lot things. So IMO, it might not be something that'll happen in the short term but we should definitely plan for it.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kkeshavamurthy]

Closing the PR since there has been no activity in 5 months. Please re-open when you work on it.