Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goss to v0.4.9 #1659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jongwooo
Copy link
Member

Change description

Updates the goss serverspec alternative tool to v0.4.9

Related issues

Additional context

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign drew-viles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2024
@jongwooo jongwooo force-pushed the goss-bump branch 2 times, most recently from e10d6d1 to 75dc6db Compare December 20, 2024 14:27
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2024
Signed-off-by: Jongwoo Han <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

@jongwooo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-goss-populate 10dacbe link true /test pull-goss-populate
pull-azure-vhds 10dacbe link true /test pull-azure-vhds
pull-gcp-all 10dacbe link true /test pull-gcp-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor

==> googlecompute.rhel-8: 2024/12/20 15:17:58 could not read json data in goss/goss-package.yaml: yaml: unmarshal errors:
==> googlecompute.rhel-8:   line 52: mapping key "cloud-init" already defined at line 17

Looks like the new goss version is more strict about things, and maybe we had a duplicated key somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update goss serverspec tool to current version
3 participants