Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Azure windows-2019 to known working version #1615

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Pin Azure windows-2019 to known working version #1615

merged 1 commit into from
Oct 24, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Oct 21, 2024 •
edited
Loading

Change description

Changes the windows-2019 build image to a known working version.

Related issues

Additional context

How to browse the relevant base images:

az vm image list \
  --publisher MicrosoftWindowsServer \
  --offer WindowsServer \
  --sku 2019-datacenter-core-smalldisk \
  --all

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@mboersma
Copy link
Contributor Author

/hold because this contains a TEMP commit

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@mboersma
Copy link
Contributor Author

This passed CI for the build-azure-*-windows-2019 jobs. I'll remove the TEMP commit.

@mboersma
Copy link
Contributor Author

/hold cancel
/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@mboersma
Copy link
Contributor Author

I used this to build community gallery images that got kubernetes-sigs/cluster-api-provider-azure#5167 unstuck, so I'm confident this is a functional workaround.

@jsturtevant
Copy link
Contributor

/lgtm
/approve

We can unpin once November patches come out. Hopefully it will be resolved then

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit ebed676 into kubernetes-sigs:main Oct 24, 2024
10 checks passed
@mboersma mboersma deleted the fix-windows-2019 branch October 24, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew-viles drew-viles Awaiting requested review from drew-viles

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @jsturtevant @k8s-ci-robot