Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): automate helm json schema #5075

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Feb 9, 2025

Description

Added script and documented how to automatically update json schema. In follow-up could add/update github actions as well.

Relates #4989 but not resolves

Fixes #4860

  • JSON schema generation
    • regenerated schema
  • Helm docs generation
  • Dev-guide
    • how to generate JSON schema
    • how to generate docs
    • how to update CHANGELOG.md

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2025
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 9, 2025
@ivankatliarchuk ivankatliarchuk changed the title helm(json-schema): simplified schema validation helm(json-schema): helm json schema enchancement Feb 9, 2025
@mloiseleur
Copy link
Contributor

Wow, I like that PR ❤️ !
I'll let @stevehipwell review it, at a first glance it looks good.

For the github action, there is one ready to go for failing on diff:
https://github.com/losisin/helm-values-schema-json-action?tab=readme-ov-file#fail-on-diff

@mloiseleur
Copy link
Contributor

/retitle feat(chart): automate helm schema

@k8s-ci-robot k8s-ci-robot changed the title helm(json-schema): helm json schema enchancement feat(chart): automate helm schema Feb 9, 2025
@mloiseleur
Copy link
Contributor

/retitle feat(chart): automate helm json schema

@k8s-ci-robot k8s-ci-robot changed the title feat(chart): automate helm schema feat(chart): automate helm json schema Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart values schema is missing an entry for the serviceMonitor property.
3 participants