Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(domain-filter): simple filters on domain exclusion #5064

Merged
merged 4 commits into from
Feb 10, 2025
Merged

test(domain-filter): simple filters on domain exclusion #5064

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6a26ca
issue(filter-tags): issue-3718 domain exclusion filters
ivankatliarchuk Feb 5, 2025
25011dc
issue(filter-tags): issue-3718 domain exclusion filters
ivankatliarchuk Feb 5, 2025
a882288
issue(filter-tags): issue-3718 domain exclusion filters
ivankatliarchuk Feb 5, 2025
5fd14e3
Apply suggestions from code review
ivankatliarchuk Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions endpoint/domain_filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"encoding/json"
"fmt"
"regexp"
"strings"
"testing"

"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -769,3 +770,51 @@ func TestDomainFilterMatchParent(t *testing.T) {
})
}
}

func TestDomainFilterWithExclusion(t *testing.T) {
ivankatliarchuk marked this conversation as resolved.
Show resolved Hide resolved
test := []struct {
domainFilter []string
exclusionFilter []string
domains []string
want []string
}{
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{"subdomain.ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{"one.subdomain.ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{".ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"ex.com", "ex.com."},
},
}

for _, tt := range test {
t.Run(fmt.Sprintf("include:%s-exclude:%s", strings.Join(tt.domainFilter, "_"), strings.Join(tt.exclusionFilter, "_")), func(t *testing.T) {
domainFilter := NewDomainFilterWithExclusions(tt.domainFilter, tt.exclusionFilter)
var got []string
for _, domain := range tt.domains {
if domainFilter.Match(domain) {
got = append(got, domain)
}
}
assert.Equal(t, len(got), len(tt.want))
assert.Equal(t, got, tt.want)
})
}
}
Loading