Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add staging images to release process #5050

Merged
merged 4 commits into from
Feb 3, 2025
Merged

docs: add staging images to release process #5050

merged 4 commits into from
Feb 3, 2025

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Jan 30, 2025 •
edited
Loading

Description

Quite often there is an ask when new release is planned. Not sure if we could answer that, but at least there a staging image available, sounds like a right decision to share this information publicly

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash
/kind docs

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-squash
/kind docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivankatliarchuk
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 30, 2025
@ivankatliarchuk ivankatliarchuk changed the title chore(docs): update release process documentation chore(docs): add staing docker image to release process docs Jan 31, 2025
@mloiseleur
Copy link
Contributor

/retitle docs: add staging images to release process

@k8s-ci-robot k8s-ci-robot changed the title chore(docs): add staing docker image to release process docs docs: add staging images to release process Jan 31, 2025
mloiseleur
mloiseleur reviewed Jan 31, 2025
View reviewed changes
docs/release.md Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

See my little suggestion, otherwise, it lgtm

@ivankatliarchuk @mloiseleur
Apply suggestions from code review
b8aeb61 
Co-authored-by: Michel Loiseleur <[email protected]>
@mloiseleur
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit b90e013 into kubernetes-sigs:master Feb 3, 2025
13 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-release-docs branch February 3, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs Awaiting requested review from szuecs

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Assignees

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivankatliarchuk @k8s-ci-robot @mloiseleur