Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix empty query for infoblox get calls #2932

Closed
wants to merge 1 commit into from

Conversation

snorwin
Copy link

@snorwin snorwin commented Aug 5, 2022

Description
Set explicit query parameters to fetch objects from the Infoblox API.

Fixes #2931

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: snorwin / name: Norwin Schnyder (a7c8b0d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @snorwin!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snorwin
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval by writing /assign @raffo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 5, 2022
@snorwin
Copy link
Author

snorwin commented Aug 7, 2022

I tried to update the mock in the unit test, however it was not possible to use the query parameters in the mock as the searchFields are unexported in ibclient.QueryParams.

@skalpin
Copy link
Contributor

skalpin commented Aug 8, 2022

@snorwin I have a similar PR #2890, but it's being ignored and I don't know why.

@snorwin
Copy link
Author

snorwin commented Aug 8, 2022

@skalpin I linked your PR as well to the issue I have created.

In addition, I opened an issue infobloxopen/infoblox-go-client#181 to improve the testability of the infoblox-go-client integration.

@snorwin
Copy link
Author

snorwin commented Aug 12, 2022

/assign @ranjishmp

@k8s-ci-robot
Copy link
Contributor

@snorwin: GitHub didn't allow me to assign the following users: ranjishmp.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ranjishmp
/assign @skalpin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@snorwin
Copy link
Author

snorwin commented Aug 12, 2022

/assign @skudriavtsev

@k8s-ci-robot
Copy link
Contributor

@snorwin: GitHub didn't allow me to assign the following users: skudriavtsev.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @skudriavtsev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

@snorwin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@snorwin
Copy link
Author

snorwin commented Aug 18, 2022

Fixed by #2890

@snorwin snorwin closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infoblox provider deletes all fetched records if any DNS record is updated
3 participants