-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix empty query for infoblox get calls #2932
Conversation
|
Welcome @snorwin! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snorwin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3ab4675
to
a7c8b0d
Compare
I tried to update the mock in the unit test, however it was not possible to use the query parameters in the mock as the |
@skalpin I linked your PR as well to the issue I have created. In addition, I opened an issue infobloxopen/infoblox-go-client#181 to improve the testability of the infoblox-go-client integration. |
/assign @ranjishmp |
@snorwin: GitHub didn't allow me to assign the following users: ranjishmp. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @skudriavtsev |
@snorwin: GitHub didn't allow me to assign the following users: skudriavtsev. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@snorwin: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed by #2890 |
Description
Set explicit query parameters to fetch objects from the Infoblox API.
Fixes #2931
Checklist