feat: add vcluster e2e cluster provider

[crandles]

addition of vcluster provider; interested to see if the CI fails. vcluster needs a "host" cluster to launch into, so I've followed an existing example where a real cluster or kind cluster are utilized as necessary:

e2e-framework/examples/real_cluster/main_test.go

Line 39 in 9206e6f

if os.Getenv("REAL_CLUSTER") == "true" {

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables a new E2EClusterProvider for vcluster based clusters.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., Usage docs, etc.:

NA

[k8s-ci-robot]

Hi @crandles. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vladimirvivien]

@crandles this is awesome and thanks for the contribution.
At first glance it looks Okay, but I will ask @harshanarayana to take a look as well since he's the E2E provider expert 😉

[vladimirvivien]

This is a great start. I left some comments.

[vladimirvivien]

I think @harshanarayana has some util wrapper for running procs that should be considered here.

[vladimirvivien]

@crandles does this vcluster create function will only work for kind "real" clusters (i don't know much about vclusters). If that is the case, you may wanna consider making that clear in naming (i.e. third_party/kind_vcluster).

[crandles]

No, this doesn't require kind, this should work in any host k8s cluster.

I set it up via kind in the example so that it could presumably execute successfully (doubting there's a real cluster to access otherwise within CI).

I'd expect normal usage would be against your preferred existing AWS or Google flavored kubernetes cluster.

[vladimirvivien]

This looks good to me.
LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crandles, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vladimirvivien]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[crandles]

Updated copyright, verify-boilerplate passes locally now.

[vladimirvivien]

/retest

[k8s-ci-robot]

@crandles: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-e2e-framework-verify	3cd2451	link	true	/test pull-e2e-framework-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[crandles]

golangci appears to be passing now for thew new code I've added, though errirng for some existing LOC:

third_party/helm/helm.go:240:9: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
		err = fmt.Errorf(missingHelm)
		      ^
third_party/flux/flux_setup.go:47:16: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
			return ctx, fmt.Errorf(NoFluxInstallationFoundMsg)
			            ^
third_party/flux/flux_setup.go:61:16: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
			return ctx, fmt.Errorf(NoFluxInstallationFoundMsg)
			            ^
pkg/env/env.go:229:11: printf: non-constant format string in call to (*testing.common).Skipf (govet)
		t.Skipf(message)
		        ^
pkg/env/env.go:513:22: printf: non-constant format string in call to (*testing.common).Skipf (govet)
					internalT.Skipf(message)

Assuming that won't block this PR.

[vladimirvivien]

@harshanarayana and @cpanato any idea why golangci failing on previously working code ?

[crandles]

errors were primarily for:

SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)

It's possible that I'm using a different toolchain version, but as the warning seemed fair, I've fixed it via cf9cbf2

make verify now passes locally.