CLI flags for "running only given features" will skip whole test if a feature in the env doesn't match the criteria.

[0sewa0]

What happened?

When using the --labels "key=value" argument, the Feature with that label didn't run.
All Features got skipped, regardless of the label they have, because the first in the Environment didn't have the label.

What did you expect to happen?

Run all the Features that have the label, and skip the ones that don't.

How can we reproduce it (as minimally and precisely as possible)?

Have 2 Features, only second one has the label, try to run only the second one using the --labels arg.

Anything elese we need to know?

Tried it with the --feature arg as well, same problem.

E2E Provider Used

real cluster

e2e-framework Version

v0.4.0

OS version

OS: MacOS 14.5 (Intel Machine)

[0sewa0]

I am not familiar with the code(at all), and how it's structured, but out of curiosity, I went digging:

I think https://github.com/kubernetes-sigs/e2e-framework/blame/72aa5e3c117ef7c0a430328fa4b6e61edbdcf790/pkg/env/env.go#L209-L212 is incorrect.

• Doesn't t.Skipf just skip the whole test, not only the Feature? 🤔
• Wouldn't a simple return ctx be a fix ? (with some log before it, of course 😅 )

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale