-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ Allow a user to provide a custom metric provider for firing metrics #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Allow a user to provide a custom metric provider for firing metrics #3213
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9d9a6f4
to
d9a3844
Compare
/test all |
3c12e38
to
33ac26c
Compare
/test all |
33ac26c
to
9103ac4
Compare
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than introducing the complexity of making this configurable its preferred to instead add the controller-runtime metrics registry to your own, here is an example of doing it with otel: #305 (comment)
/hold
Fixes #3094
This change updates controller-runtime to expose MetricProviders for all of the subsystems where we expose metrics. This allows other controllers that leverage controller-runtime to do things like forward metrics to EMF (Embedded Metrics Format on AWS) rather than exposing them through Prometheus