🌱 Improve patch helper error handling #9946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
7 tasks
sbueringer
force-pushed
the
pr-patch-helper-err-handling
branch
from
24e3a7e to
ca41ad8
Compare
sbueringer
force-pushed
the
pr-patch-helper-err-handling
branch
from
ca41ad8 to
2f29684
Compare
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-patch-helper-err-handling
branch
from
2f29684 to
1c760a5
Compare
vincepri
reviewed
Jan 2, 2024
| @@ -741,7 +741,7 @@ func pauseClusterClass(ctx context.Context, proxy Proxy, n *node, pause bool, mu | |||
|
|
|||
| patchHelper, err := patch.NewHelper(clusterClass, cFrom) | |||
| if err != nil { | |||
| return errors.Wrapf(err, "error creating patcher for ClusterClass %s/%s", n.identity.Namespace, n.identity.Name) | |||
There was a problem hiding this comment.
This seems useful information to keep?
There was a problem hiding this comment.
Nevermind, I see this is covered in the inner calls
There was a problem hiding this comment.
Yup. I kept additional wrapping only if it provided additional information
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 68bd831ee657173937ab24f74ca349a64b75d4f9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
With this PR the patch helper returns errors with the entire available error context. Before this PR we only added error context in some cases and very inconsistently
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #