Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Give permissions for release notes tool to release team #9563

Merged
merged 1 commit into from
Nov 2, 2023
Merged

🌱 Give permissions for release notes tool to release team #9563

merged 1 commit into from
Nov 2, 2023

Conversation

g-gaston
Copy link
Contributor

What this PR does / why we need it:
Give the release team more autonomy to iterate on the release tool.

Which issue(s) this PR fixes:
Fixes #9524

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@g-gaston
Copy link
Contributor Author

cc @kubernetes-sigs/cluster-api-release-team @killianmuldoon @CecileRobertMichon

killianmuldoon
killianmuldoon reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we document in the release docs that this folder, and the docs/release folder have these permissions? Could be a good pointer for future release teams.

@g-gaston
Copy link
Contributor Author

Could we document in the release docs that this folder, and the docs/release folder have these permissions? Could be a good pointer for future release teams.

I don't have a strong opinion
@furkatgofurov7 opinions?

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Oct 17, 2023 •
edited
Loading

Could we document in the release docs that this folder, and the docs/release folder have these permissions? Could be a good pointer for future release teams.

I don't have a strong opinion @furkatgofurov7 opinions?

No strong opinion either, but might be useful to document it since future teams know in advance what is possible / not when it comes to reviewing/merging the PRs in specific folders without waiting for maintainers. Probably, it fits better somewhere in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-team.md document

@g-gaston g-gaston force-pushed the permissions-release-tool branch from d97eec7 to 838e272 Compare October 18, 2023 14:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2023
@g-gaston g-gaston force-pushed the permissions-release-tool branch from 838e272 to 15442ce Compare October 18, 2023 14:29
@g-gaston
Copy link
Contributor Author

@killianmuldoon @furkatgofurov7
Added a section in the docs :)

furkatgofurov7
furkatgofurov7 reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03dd521e3077ff58b18ec7b57735266dc899958c

@killianmuldoon
Copy link
Contributor

/lgtm

Would like to get a another maintainer to approve given this is an Owner file change.

@furkatgofurov7
Copy link
Member

/cc @vincepri

@k8s-ci-robot k8s-ci-robot requested a review from vincepri October 19, 2023 12:00
neolit123
neolit123 reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killianmuldoon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit af64722 into kubernetes-sigs:main Nov 2, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@neolit123 neolit123 neolit123 left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Release tool review permissions for release team
5 participants
@g-gaston @furkatgofurov7 @k8s-ci-robot @killianmuldoon @neolit123