-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fix Equinix metal link in docs #9514
📖 Fix Equinix metal link in docs #9514
Conversation
Signed-off-by: killianmuldoon <[email protected]>
@@ -539,7 +539,7 @@ clusterctl init --infrastructure docker | |||
In order to initialize the Equinix Metal Provider (formerly Packet) you have to expose the environment | |||
variable `PACKET_API_KEY`. This variable is used to authorize the infrastructure | |||
provider manager against the Equinix Metal API. You can retrieve your token directly | |||
from the [Equinix Metal Console](https://console.equinix.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@displague I think you added this in #5774. Do you know if there's any alternative link? This one is now giving a 403 for the MD link checker. I'd prefer to remove it if there's no easy substitution.
/cherry-pick release-1.5 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If this is creating noise on PRs, let's merge as it is, we can always add the link later |
Generally agreed - currently we don't run the full link checker on PRs so this is just failing the weekly job. I'm fine to merge as is though. |
/lgtm |
@killianmuldoon: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini @chrischdi mind putting lgtm on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: ac261e6e560dd82d9f60c58e9e670d12b642f36d
|
@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.5 |
@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 These cherry-picks failed with the issues k8s-infra-cherrypick-robot had. Should be fixed now. |
@killianmuldoon: new pull request created: #9596 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #9597 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix a broken link in the docs.
/area documentation