-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add clustercache metrics #11789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add clustercache metrics #11789
Conversation
Skipping CI for Draft Pull Request. |
thanks for the review @sbueringer, everything except the label enhancement should be addressed (still have to look into this a bit) |
Last comment from my side: #11789 (comment) |
Nice improvement, thanks @cahillsf /lgtm |
LGTM label has been added. Git tree hash: 5e7e97cf3992585c92ecf17d30197ac780d234ed
|
Thank you! /lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great to have those new metrics, thanks @cahillsf /hold cancel |
@cahillsf Thank you very much!! |
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #11272
/area clustercache