Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🌱 Bump cert-manager to v1.16.3 #11725

Closed
wants to merge 1 commit into from
Closed

[release-1.8] 🌱 Bump cert-manager to v1.16.3 #11725

wants to merge 1 commit into from

Conversation

troy0820
Copy link
Member

Cherry-pick #11699

/area clusterctl

@troy0820
bump cert-manager to v1.16.3
5e5984e 
Signed-off-by: Troy Connor <[email protected]>
@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 21, 2025
@troy0820 troy0820 changed the base branch from main to release-1.8 January 21, 2025 14:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2025
@troy0820 troy0820 changed the title Update cert manager v1.8 release 🌱Update cert manager v1.8 release Jan 21, 2025
@sbueringer sbueringer changed the title 🌱Update cert manager v1.8 release [release-1.8] 🌱 Bump cert-manager to v1.16.3 Jan 21, 2025
@sbueringer
Copy link
Member

sbueringer commented Jan 21, 2025 •
edited
Loading

Changes are fine. Not sure if there is a way to fix the PR without reopening it / opening a new one

@chrischdi
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@troy0820: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-test-main 5e5984e link unknown /test pull-cluster-api-test-main
pull-cluster-api-apidiff-main 5e5984e link unknown /test pull-cluster-api-apidiff-main
pull-cluster-api-build-main 5e5984e link unknown /test pull-cluster-api-build-main
pull-cluster-api-verify-main 5e5984e link unknown /test pull-cluster-api-verify-main
pull-cluster-api-e2e-blocking-main 5e5984e link true /test pull-cluster-api-e2e-blocking-main
pull-cluster-api-apidiff-release-1-8 5e5984e link false /test pull-cluster-api-apidiff-release-1-8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@troy0820
Copy link
Member Author

Changes are fine. Not sure if there is a way to fix the PR without reopening it / opening a new one

I'll close this one and reopen a new one.

@troy0820 troy0820 closed this Jan 21, 2025
@sbueringer
Copy link
Member

kk thx. Prow doesn't like base branch changes :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@enxebre enxebre Awaiting requested review from enxebre

Assignees
No one assigned
Labels
area/clusterctl Issues or PRs related to clusterctl cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@troy0820 @k8s-ci-robot @sbueringer @chrischdi