🌱 add TypedAll, ResourceIsUnchanged and TypedResourceIsUnchanged predicates #11597
Conversation
k8s-ci-robot
added
area/util
k8s-ci-robot
added
the
size/L
chrischdi
added
the
tide/merge-method-squash
chrischdi
force-pushed
the
pr-unchanged-predicate-secondary-watch
branch
from
cffb23b to
887ee67
Compare
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-conformance-ci-latest-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6247f7002aa3792a514032999f4acefcd9f318db
|
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
k8s-ci-robot
removed
the
lgtm
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Stefan Büringer [email protected]
|
/lgtm Leaving approve to Fabrizio as I had to push a small fix |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7e4b84632f1f2f74850d68dfb4d34e7693df15e2
|
|
/cherry-pick release-1.9 |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
|
@chrischdi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Given that Christian reviewed my commit |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chrischdi: new pull request created: #11603 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
When hitting the resync period: additional watches lead to additional re-reconciliations.
To prevent this unnecessary work (because we did reconcile the resync event for the secondary object on the main object too) we add a predicate which filters out the event when a "secondary object"'s Generation is unchanged.
Note: the same way, controller-runtime identifies the priority of an event (new feature):
https://github.com/kubernetes-sigs/controller-runtime/pull/3014/files#diff-3933f25e7d6df3b6e84e6ef6f0d67d5583abc10ec8232fe2f584990ce6da6521R175-R176
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area util