-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support disabling CAPD load balancer #11412
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @phoban01! |
Hi @phoban01. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
# Conflicts: # controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go # controlplane/kubeadm/internal/controllers/status.go # controlplane/kubeadm/internal/controllers/status_test.go
* Implement MS remediating conditions Signed-off-by: Stefan Büringer [email protected] * Fix review findings * Fix review findings Signed-off-by: Stefan Büringer [email protected] --------- Signed-off-by: Stefan Büringer [email protected]
# Conflicts: # controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
…t check errors (kubernetes-sigs#11390) * Extend MS ScalingUp and Remediationg conditions to include preflight check errors Signed-off-by: Stefan Büringer [email protected] * Always set message on OwnerRemediated condition Signed-off-by: Stefan Büringer [email protected] --------- Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Stefan Büringer [email protected]
Bumps the all-github-actions group with 2 updates: [tj-actions/changed-files](https://github.com/tj-actions/changed-files) and [softprops/action-gh-release](https://github.com/softprops/action-gh-release). Updates `tj-actions/changed-files` from 45.0.3 to 45.0.4 - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@c3a1bb2...4edd678) Updates `softprops/action-gh-release` from 2.0.9 to 2.1.0 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@e7a8f85...01570a1) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-github-actions - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
… 4 updates Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text) and [golang.org/x/net](https://github.com/golang/net). Bumps the all-go-mod-patch-and-minor group with 4 updates in the /hack/tools directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text), [google.golang.org/api](https://github.com/googleapis/google-api-go-client) and [golang.org/x/net](https://github.com/golang/net). Bumps the all-go-mod-patch-and-minor group with 3 updates in the /test directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text) and [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0 - [Commits](golang/oauth2@v0.23.0...v0.24.0) Updates `golang.org/x/text` from 0.19.0 to 0.20.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.19.0...v0.20.0) Updates `golang.org/x/net` from 0.30.0 to 0.31.0 - [Commits](golang/net@v0.30.0...v0.31.0) Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0 - [Commits](golang/oauth2@v0.23.0...v0.24.0) Updates `golang.org/x/text` from 0.19.0 to 0.20.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.19.0...v0.20.0) Updates `google.golang.org/api` from 0.204.0 to 0.205.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.204.0...v0.205.0) Updates `golang.org/x/net` from 0.30.0 to 0.31.0 - [Commits](golang/net@v0.30.0...v0.31.0) Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0 - [Commits](golang/oauth2@v0.23.0...v0.24.0) Updates `golang.org/x/text` from 0.19.0 to 0.20.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.19.0...v0.20.0) Updates `golang.org/x/net` from 0.30.0 to 0.31.0 - [Commits](golang/net@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/oauth2 dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Sunnatillo <[email protected]>
…etes-sigs#11135) * 🌱 clusterctl: add nutanix ipam provider * 🌱 clusterctl: add nutanix runtime extensions provider * docs: Add more info on github org prefix
6bb92f8
to
794de1f
Compare
What this PR does / why we need it:
In certain scenarios it may be desirable to deploy CAPD machines without a load-balancer.
For example, in the case of a hosted control plane such as a Kamaji the load-balancer will be fulfilled by the control plane provider (indirectly at least).
This PR adds a field to the
DockerCluster
API to skip the creation/deletion of the load balancer.This change is opt-in and has no impact on existing usage.
/area provider/infrastructure-docker