Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support disabling CAPD load balancer #11412

Closed
wants to merge 20 commits into from

Conversation

phoban01
Copy link

What this PR does / why we need it:

In certain scenarios it may be desirable to deploy CAPD machines without a load-balancer.

For example, in the case of a hosted control plane such as a Kamaji the load-balancer will be fulfilled by the control plane provider (indirectly at least).

This PR adds a field to the DockerCluster API to skip the creation/deletion of the load balancer.

apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerCluster
...
spec:
  loadBalancer:
    disable: true

This change is opt-in and has no impact on existing usage.

/area provider/infrastructure-docker

@k8s-ci-robot k8s-ci-robot added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Nov 13, 2024
Copy link

linux-foundation-easycla bot commented Nov 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @phoban01!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @phoban01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2024
phoban01 and others added 20 commits November 13, 2024 15:02
# Conflicts:
#	controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
#	controlplane/kubeadm/internal/controllers/status.go
#	controlplane/kubeadm/internal/controllers/status_test.go
* Implement MS remediating conditions

Signed-off-by: Stefan Büringer [email protected]

* Fix review findings

* Fix review findings

Signed-off-by: Stefan Büringer [email protected]

---------

Signed-off-by: Stefan Büringer [email protected]
# Conflicts:
#	controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
…t check errors (kubernetes-sigs#11390)

* Extend MS ScalingUp and Remediationg conditions to include preflight
check errors

Signed-off-by: Stefan Büringer [email protected]

* Always set message on OwnerRemediated condition

Signed-off-by: Stefan Büringer [email protected]

---------

Signed-off-by: Stefan Büringer [email protected]
Bumps the all-github-actions group with 2 updates: [tj-actions/changed-files](https://github.com/tj-actions/changed-files) and [softprops/action-gh-release](https://github.com/softprops/action-gh-release).


Updates `tj-actions/changed-files` from 45.0.3 to 45.0.4
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@c3a1bb2...4edd678)

Updates `softprops/action-gh-release` from 2.0.9 to 2.1.0
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@e7a8f85...01570a1)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-github-actions
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
… 4 updates

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text) and [golang.org/x/net](https://github.com/golang/net).
Bumps the all-go-mod-patch-and-minor group with 4 updates in the /hack/tools directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text), [google.golang.org/api](https://github.com/googleapis/google-api-go-client) and [golang.org/x/net](https://github.com/golang/net).
Bumps the all-go-mod-patch-and-minor group with 3 updates in the /test directory: [golang.org/x/oauth2](https://github.com/golang/oauth2), [golang.org/x/text](https://github.com/golang/text) and [golang.org/x/net](https://github.com/golang/net).


Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0
- [Commits](golang/oauth2@v0.23.0...v0.24.0)

Updates `golang.org/x/text` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.19.0...v0.20.0)

Updates `golang.org/x/net` from 0.30.0 to 0.31.0
- [Commits](golang/net@v0.30.0...v0.31.0)

Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0
- [Commits](golang/oauth2@v0.23.0...v0.24.0)

Updates `golang.org/x/text` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.19.0...v0.20.0)

Updates `google.golang.org/api` from 0.204.0 to 0.205.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.204.0...v0.205.0)

Updates `golang.org/x/net` from 0.30.0 to 0.31.0
- [Commits](golang/net@v0.30.0...v0.31.0)

Updates `golang.org/x/oauth2` from 0.23.0 to 0.24.0
- [Commits](golang/oauth2@v0.23.0...v0.24.0)

Updates `golang.org/x/text` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.19.0...v0.20.0)

Updates `golang.org/x/net` from 0.30.0 to 0.31.0
- [Commits](golang/net@v0.30.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/net
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/text
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/net
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/oauth2
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/text
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…etes-sigs#11135)

* 🌱 clusterctl: add nutanix ipam provider

* 🌱 clusterctl: add nutanix runtime extensions provider

* docs: Add more info on github org prefix
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@phoban01 phoban01 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants