Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 MachineSet controller: delete Bootstrap object when creating InfraMachine object failed #11211

Merged
merged 1 commit into from
Jan 20, 2025
Merged

🌱 MachineSet controller: delete Bootstrap object when creating InfraMachine object failed #11211

merged 1 commit into from
Jan 20, 2025

Conversation

goushicui
Copy link
Contributor

What this PR does / why we need it:
If you do not delete the bootstrapRef after failing to create the machineRef, it will cause the bootstrapRef to leak.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @goushicui. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
chrischdi
chrischdi reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area machineset

/ok-to-test

Thanks for opening this.

Could we also maybe add an unit test for this?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/machineset Issues or PRs related to machinesets and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-area PR is missing an area label labels Sep 20, 2024
@sbueringer sbueringer changed the title delete bootstrapRef when create infraRef failed 🌱 MachineSet: controller delete Bootstrap object when creating InfraMachine object failed Sep 23, 2024
@sbueringer sbueringer changed the title 🌱 MachineSet: controller delete Bootstrap object when creating InfraMachine object failed 🌱 MachineSet controller: delete Bootstrap object when creating InfraMachine object failed Sep 23, 2024
@chrischdi
Copy link
Member

@goushicui do you maybe have some time to take a look at the comments?

@goushicui
Copy link
Contributor Author

Sorry, I’ll update it later. @chrischdi

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2024
@goushicui
Copy link
Contributor Author

@chrischdi @sbueringer updates have been made. Please help with the review. Thank you!

@goushicui
Copy link
Contributor Author

/retest-required

@goushicui goushicui force-pushed the cleanbootstrap branch 2 times, most recently from 664a5d6 to 3a06b48 Compare December 8, 2024 13:42
@goushicui goushicui force-pushed the cleanbootstrap branch 3 times, most recently from 68434ce to a2386d3 Compare January 7, 2025 16:09
@goushicui
Copy link
Contributor Author

@vincepri @chrischdi @sbueringer Please help review it when you have time. Thank you!

chrischdi
chrischdi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, as of that lgtm

@goushicui
Copy link
Contributor Author

Please help review it again. Thank you @chrischdi

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48d70802f24dc77596d89b0f369779f9470b128b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 02e03de into kubernetes-sigs:main Jan 20, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 20, 2025
@cprivitere cprivitere mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri left review comments

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@goushicui @k8s-ci-robot @chrischdi @sbueringer @vincepri