Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add NamingStrategy to MachineDeployment #11172

Merged
merged 1 commit into from
Jan 22, 2025
Merged

🌱 Add NamingStrategy to MachineDeployment #11172

merged 1 commit into from
Jan 22, 2025

Conversation

adilGhaffarDev
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #10577

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from 61ad775 to e03d550 Compare September 11, 2024 14:18
@enxebre
Copy link
Member

enxebre commented Oct 2, 2024

/hold
on #11123 so we make sure feedback there is incorporated here

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from e03d550 to 3559d2c Compare October 23, 2024 07:43
@adilGhaffarDev
Copy link
Contributor Author

/area machineset
/area machinedeployment

@k8s-ci-robot k8s-ci-robot added area/machineset Issues or PRs related to machinesets area/machinedeployment Issues or PRs related to machinedeployments and removed do-not-merge/needs-area PR is missing an area label labels Oct 23, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch 2 times, most recently from f588f68 to 10956bd Compare October 28, 2024 11:44
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review October 28, 2024 11:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from 10956bd to 2cf9110 Compare October 28, 2024 14:59
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Add NamingStrategy to MachineDeployment wip:🌱 Add NamingStrategy to MachineDeployment Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch 2 times, most recently from 5438128 to 6c5de96 Compare October 29, 2024 08:23
@adilGhaffarDev adilGhaffarDev changed the title wip:🌱 Add NamingStrategy to MachineDeployment 🌱 Add NamingStrategy to MachineDeployment Oct 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@adilGhaffarDev
Copy link
Contributor Author

cc @sbueringer @fabriziopandini @chrischdi
This one is ready for review, please check.

@lentzi90
Copy link
Contributor

I have verified that it is working as expected with a real end-to-end test. Thanks for working on this @adilGhaffarDev !

@chrischdi
Copy link
Member

The last findings I could find. As of that lgtm

@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from 49ebdf5 to 09cc313 Compare January 15, 2025 07:55
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 824b6672a22ae23e06110c8c8b7073e9088175cc

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2025
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from 09cc313 to b60f1fd Compare January 21, 2025 09:21
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2025
@adilGhaffarDev
Copy link
Contributor Author

The last findings I could find. As of that lgtm

rebased the PR please re lgtm

@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from b60f1fd to 9ce4cf9 Compare January 21, 2025 09:28
sbueringer
sbueringer reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few smaller findings

internal/webhooks/machinedeployment.go Show resolved Hide resolved
api/v1beta1/machinedeployment_types.go Outdated Show resolved Hide resolved
api/v1beta1/machinedeployment_types.go Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_sync.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_sync_test.go Outdated Show resolved Hide resolved
internal/controllers/machineset/machineset_controller.go Outdated Show resolved Hide resolved
internal/controllers/machineset/machineset_controller.go Outdated Show resolved Hide resolved
internal/controllers/machineset/machineset_controller_test.go Outdated Show resolved Hide resolved
@adilGhaffarDev
Add NamingStrategy to MachineDeployment
42e26cb 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev adilGhaffarDev force-pushed the md-naming-issue-fix/adil branch from 9ce4cf9 to 42e26cb Compare January 22, 2025 08:21
@sbueringer
Copy link
Member

Thank you very much!

/lgtm

/assign @fabriziopandini @chrischdi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a647f7a9910c04d2e440946e792c539270e40291

@fabriziopandini
Copy link
Member

Great work!
/lgtm

chrischdi
chrischdi reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5a77e93 into kubernetes-sigs:main Jan 22, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 22, 2025
@sbueringer
Copy link
Member

sbueringer commented Jan 22, 2025 •
edited
Loading

Thanks everyone for working on this, really appreciate it. I know it took a while and some patience :)
(realistically mostly due to maintainer bandwith limitations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma left review comments

@chrischdi chrischdi chrischdi left review comments

@enxebre enxebre enxebre left review comments

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinedeployment Issues or PRs related to machinedeployments area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
8 participants
@adilGhaffarDev @k8s-ci-robot @enxebre @lentzi90 @sbueringer @chrischdi @fabriziopandini @mboersma