Skip to content
PR golangci-lint

[release-1.8] 🐛 Export runtime.Client interface and cache package #6837

Sign in to view logs

[release-1.8] 🐛 Export runtime.Client interface and cache package

[release-1.8] 🐛 Export runtime.Client interface and cache package #6837

Triggered via pull request December 23, 2024 11:44
@sbueringersbueringer
opened #11613
sbueringer:pr-fix-runtime-client-import-1.8
Status Failure
Total duration 3m 50s
Artifacts –

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 3 warnings
lint (test)
golangci-lint exit with code 3
lint: controllers/alias.go#L31
could not import sigs.k8s.io/cluster-api/internal/controllers/machine (-: # sigs.k8s.io/cluster-api/internal/controllers/machine
lint: internal/controllers/machine/machine_controller.go#L54
"sigs.k8s.io/cluster-api/util/cache" imported and not used) (typecheck)
lint: internal/controllers/cluster/suite_test.go#L36
could not import sigs.k8s.io/cluster-api/internal/controllers/machine (-: # sigs.k8s.io/cluster-api/internal/controllers/machine
lint: internal/controllers/machine/machine_controller.go#L54
"sigs.k8s.io/cluster-api/util/cache" imported and not used) (typecheck)
lint: internal/controllers/clusterclass/clusterclass_controller_test.go#L45
runtimeclient redeclared in this block
lint: internal/controllers/clusterclass/clusterclass_controller_test.go#L41
other declaration of runtimeclient
lint: internal/controllers/clusterclass/clusterclass_controller_test.go#L45
"sigs.k8s.io/cluster-api/internal/runtime/client" imported as runtimeclient and not used (typecheck)
lint: internal/controllers/machine/machine_controller.go#L54
"sigs.k8s.io/cluster-api/util/cache" imported and not used
lint: internal/controllers/machine/machine_controller_test.go#L48
"sigs.k8s.io/cluster-api/util/cache" imported and not used (typecheck)
lint: internal/controllers/machinedeployment/suite_test.go#L43
could not import sigs.k8s.io/cluster-api/internal/controllers/machine (-: # sigs.k8s.io/cluster-api/internal/controllers/machine
lint (hack/tools)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint (test)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636