Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 CI: Increase IOPS for the devstack disks #2316

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Dec 11, 2024

What this PR does / why we need it:

This is an attempt to see if disk performance is what makes our CI unstable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 50939b8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6759715f1447e3000750a7c3
😎 Deploy Preview https://deploy-preview-2316--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This is an attempt to see if disk performance is what makes our CI
unstable.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/ci-hyperdisk branch from a590bb9 to 50939b8 Compare December 11, 2024 11:02
@lentzi90
Copy link
Contributor Author

So far so good with larger disk. The larger the disk, the better the performance.

  • Devstack success 1
  • Devstack failure 0

@lentzi90 lentzi90 changed the title 🌱 CI: Use hyperdisk-balanced for devstack 🌱 CI: Increase IOPS for the devstack disks Dec 11, 2024
@lentzi90
Copy link
Contributor Author

Rerunning a few times to get some statistics...
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Devstack success 2
Devstack failure 0
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Devstack success 2
Devstack failure 1 😞
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

/lgtm
feel free to approve when you feel it's ready

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@EmilienM
Copy link
Contributor

let's consider #2319 as well

@lentzi90
Copy link
Contributor Author

Devstack success 3
Devstack failure 1
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Devstack success 4
Devstack failure 1
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Devstack success 5
Devstack failure 1
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

6 to 1 is better than what we seen in the periodics. I think the best there has been 4 successful in a row.
/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@EmilienM
Copy link
Contributor

/cherry-pick release-0.11 release-0.10 release-0.9

@k8s-infra-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.11 release-0.10 release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit edf1b09 into kubernetes-sigs:main Dec 12, 2024
9 checks passed
@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2323

In response to this:

/cherry-pick release-0.11 release-0.10 release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants