Improve pre-commit UX part 2

[nawazkh]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates the below.

• run go-test in pre-push stage

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5318

Special notes for your reviewer:

• A sample git push would look like below. Note: it took me 3 mins to finish the push

~/msftcode/cluster-api-provider-azure on improve-pre-commit-ux *4                                                                                         took 13s at 01:35:26 PM
❯ ggpush --force
Run make verify-modules..................................................Passed
Run make verify-gen......................................................Passed
Run make verify-shellcheck...............................................Passed
Run make verify-conversions..............................................Passed
Run make verify-tiltfile.................................................Passed
Run make go-test.........................................................Passed
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 10 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 573 bytes | 573.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To github.com:nawazkh/cluster-api-provider-azure.git
 + 5348dcc15...71103553f improve-pre-commit-ux -> improve-pre-commit-ux (forced update)

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

NONE

[nawazkh]

/cc @mboersma

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (4b18ac2) to head (9fa2b4a).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5329      +/-   ##
==========================================
- Coverage   52.53%   52.51%   -0.02%     
==========================================
  Files         272      272              
  Lines       29422    29431       +9     
==========================================
  Hits        15457    15457              
- Misses      13166    13172       +6     
- Partials      799      802       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bryan-cox]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 21162b98cfaf4b2296e855cc67b97081d9b51bc4

[mboersma]

go test -race used to be a lot slower than just go test. Does this add a lot of time to committing? We need to keep it snappy if we want developers in general to use this.

[nawazkh]

Does this add a lot of time to committing?

Committing is still snappy. Current changes run go test in pre-push stage, so committing is still snappy. And the pre-push stage took 5 mins for me.
verify-gen and lint were the slow runners.

go test -race used to be a lot slower than just go test.

Oh. I did not look into the time delay due to race detector enabled. Lemme change it to make go-test instead.

[bryan-cox]

@nawazkh - you might want to update your commit message now.

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c478537d940437f610c2a79230ccb32f8733b744

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nawazkh]

/hold

[nawazkh]

@nawazkh - you might want to update your commit message now.

Updated the commit message, ready to ship.

[nawazkh]

/unhold

[bryan-cox]

/lgtm