Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add willie-yao to project maintainers #4826

Merged
merged 1 commit into from
May 8, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented May 7, 2024

/kind cleanup

What this PR does / why we need it:

@willie-yao has consistently demonstrated expertise and endurance on the CAPZ project. We would be grateful to have him as a maintainer.

In addition to numerous substantial contributions, here is a list of PRs reviewed recently by Willie:

I could go on...that's just the last week or two. 😄

Thanks again, Willie! CAPZ is lucky to have you.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2024
@mboersma mboersma requested review from jackfrancis, nojnhuh, Jont828 and marosset and removed request for willie-yao May 7, 2024 21:39
@nojnhuh
Copy link
Contributor

nojnhuh commented May 7, 2024

Thank you Willie!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5fdbca56131bb61d663f0475814e305e06611524

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.02%. Comparing base (d98386f) to head (a9b88fb).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4826   +/-   ##
=======================================
  Coverage   62.02%   62.02%           
=======================================
  Files         201      201           
  Lines       16857    16857           
=======================================
  Hits        10456    10456           
  Misses       5618     5618           
  Partials      783      783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor

Thank you Matt! I'm super excited to take the next step in being a maintainer for the project 🚀

@jackfrancis
Copy link
Contributor

/lgtm

Well-served @willie-yao!

/assign @Jont828

@Jont828
Copy link
Contributor

Jont828 commented May 8, 2024

Congrats @willie-yao!

/lgtm

Copy link
Contributor Author

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit bccef17 into kubernetes-sigs:main May 8, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 8, 2024
@mboersma mboersma deleted the willie-maintains branch May 8, 2024 21:05
@willie-yao
Copy link
Contributor

Thanks so much everyone!! ❤️

@marosset
Copy link
Contributor

marosset commented May 8, 2024

A little late but +1 from me!

@nawazkh
Copy link
Member

nawazkh commented May 17, 2024

Way to go Willie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants